915102 - PositionError::GetMessage converts to PositionError::GetMessageW on VS2013RC

Status: RESOLVED WORKSFORME

(Core :: DOM: Geolocation, defect)

Description

[Makoto Kato [:m_kato]]

Attachment: need undef GetMessage

When building m-c using VS2013RC, the following error occurs when linking xul.dll.

PositionErrorBinding.obj : error LNK2019: unresolved external symbol "public: virtual enum tag_nsresult __stdcall mozilla::dom::PositionError::GetMessage(class
nsAString_internal &)" (?GetMessage@PositionError@dom@mozilla@@UAG?AW4tag_nsresult@@AAVnsAString_internal@@@Z) referenced in function "bool __cdecl mozilla::dom::PositionErrorBinding::get_message(struct JSContext *,class JS::Handle<class JSObject *>,class mozilla::dom::PositionError *,class JSJitGetterCallArgs)" (?get_message@PositionErrorBinding@dom@mozilla@@YA_NPAUJSContext@@V?$Handle@PAVJSObject@@@JS@@PAVPositionError@23@VJSJitGetterCallArgs@@@Z)
xul.dll : fatal error LNK1120: 1 unresolved externals
c:\Development\hg.mozilla.org\mozilla-vs\config\rules.mk:1018:0: command 'c:/Dev


This is well-known issue by GetMessage macro.

Comment 1

[Josh Matthews [:jdm]]

Comment on attachment 802938 [details] [diff] [review]
need undef GetMessage

Review of attachment 802938 [details] [diff] [review]:
-----------------------------------------------------------------

/me weeps

Comment 2

[(no longer active)]

Please feel free to add a sad comment when landing this:

<http://mxr.mozilla.org/mozilla-central/search?string=Thanks%20so%20much%2C%20Microsoft!>

:(

Comment 3

[(not currently active) Ted Mielczarek]

Any reason we can't just use [binaryname] in the IDL for this?
http://mxr.mozilla.org/mozilla-central/source/dom/mobilemessage/interfaces/nsIMobileMessageDatabaseService.idl#22

Comment 4

[Josh Matthews [:jdm]]

If we did, we'd use binaryNames in Bindings.conf: http://mxr.mozilla.org/mozilla-central/source/dom/bindings/Bindings.conf#1512

Comment 6

[(no longer active)]

(In reply to comment #3)
> Any reason we can't just use [binaryname] in the IDL for this?
> http://mxr.mozilla.org/mozilla-central/source/dom/mobilemessage/interfaces/nsIMobileMessageDatabaseService.idl#22

I think that's not a great idea.  No need to mess up the name for everybody.

Comment 7

[(not currently active) Ted Mielczarek]

Okay. If you're going to do this in a header file, though, you should probably use #pragma push_macro/pop_macro to avoid screwing up the defines of people including the header.

Example:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/third_party/lss/linux_syscall_support.h#127
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/third_party/lss/linux_syscall_support.h#3527

Comment 8

[(not currently active) Ted Mielczarek]

Also, FWIW, "everyone" is kind of strong. This interface+class looks to be used in all of one C++ file:
http://mxr.mozilla.org/mozilla-central/source/dom/src/geolocation/nsGeolocation.cpp

Comment 9

[(no longer active)]

The #pragma idea is a good one, I think.  FWIW I don't feel extremely strongly about this either way.

Comment 10

[Makoto Kato [:m_kato]]

If using #pragma instead of, we should add workaround of the following functions.
http://mxr.mozilla.org/mozilla-central/ident?i=CreateEvent
http://mxr.mozilla.org/mozilla-central/ident?i=GetClassName

Comment 11

[Masatoshi Kimura [:emk]]

Build didn't fail with VS 2013 RTM for me.