Closed Bug 915141 Opened 9 years ago Closed 9 years ago

Can't check/uncheck "Log Request and Response Bodies" by using the keyboard

Categories

(DevTools :: Console, defect, P3)

24 Branch
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 30

People

(Reporter: ioana_damy, Assigned: sjakthol)

References

Details

(Keywords: regression)

Attachments

(1 file)

Reproducible on Firefox 24, 25 and 26, on multiple OSs.
Introduced with the fix for bug 879799.

STR:
1. Launch Firefox.
2. Open the Browser Console.
3. Navigate through the console using the keyboard. With the focus on Net, press Enter.
4. Use the arrows to move the focus to "Log Request and Response Bodies".
5. Press Enter.

Expected Results:
"Log Request and Response Bodies" gets checked/unchecked (work the same as the other options).

Actual Results:
The menu gets closed, but nothing else happens.
Depends on: 879799
Keywords: regression
Priority: -- → P3
A patch that solves this issue by listening for 'command' event instead of a 'click' event.
Attachment #8380202 - Flags: review?(mihai.sucan)
Comment on attachment 8380202 [details] [diff] [review]
devtools-console-keyboard-toggle-log-response-bodies.patch

Review of attachment 8380202 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch. This is looking good.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=2fd6c3f61f1c
Attachment #8380202 - Flags: review?(mihai.sucan) → review+
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Try push results seem green enough.

Landed: https://hg.mozilla.org/integration/fx-team/rev/5bc4fa17cd79

Thanks for your patches! Good work.
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5bc4fa17cd79
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
Keywords: verifyme
This issue is verified fixed on Aurora 30 (2014-04-23) and Nightly 31 (2014-04-23), using Windows 7 64-bit [1], Ubuntu 12.04 32-bit [2] and Mac OS X 10.9 [3].

1. Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0
2. Mozilla/5.0 (X11; Linux i686; rv:30.0) Gecko/20100101 Firefox/30.0
3. Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:30.0) Gecko/20100101 Firefox/30.0
Status: RESOLVED → VERIFIED
Keywords: verifyme
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.