915195 - InvalidateFrameSubtree and the stuff under it could be faster

Status: NEW

(Core :: Layout, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Last night I wondered why FF seemed to take quite some cpu power occasionally, so I
got few profiles and nsIFrame::InvalidateFrameSubtree and stuff under it seemed to take significant amout time.
InvalidateDirectRenderingObservers is also in the profiles.

There are few simple minor optimizations; for example make sure
nsSVGEffects::InvalidateDirectRenderingObservers isn't  even called if there are no observers (so, inline parts of nsSVGEffects::InvalidateDirectRenderingObservers),

The profiler also suggested making InvalidateFrameSubtree non-recursive.

I wonder if bug 870430 would have helped.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Ah, looks like we have something like bug 870430 in the tree now.

Comment 2

[Jonathan Watt [:jwatt]]

Do you have a link to a profile and the URL of the page you were viewing when you saw the perf issues? Also which code are you referring to in comment 1?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

part of the profile, https://pastebin.mozilla.org/3026585, total time%, and self time%

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

This could be related to bug 912769