915200 - Icon duplication in content added to page with page template

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect)

Description

[Trevor]

There is some strange icon duplication in content added to the page by the page template {{ page('en-US/docs/JavaScript/Reference/Global_Objects/Object/prototype', 'Properties') }}

Comment 1

[Trevor]

The page template gets it content from:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/prototype?raw=1&macros=1&include=1&section=Properties

Looking at the source of that page the closing </i> has been stripped from the content
...  <span title="This API has not been standardized."><i class="icon-warning-sign"/></span></dt> ...

If you drop &include=1 from the url:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/prototype?raw=1&macros=1&section=Properties
then the closing </i> is not removed and icon duplication no longer occurs.

Comment 2

[Jean-Yves Perrier [:teoli]]

Sheppy: this looks pretty severe. A lot of pages (XUL/JavaScript) are affected. Could you have a look? I have no experience around these icons and scripts.

As we plan a regeneration later this week, we need to fix this at the same time.

Comment 3

[Trevor]

As a temporary workaround we have added spaces inside the <i> tags used by these templates
NonStandardBadge
DeprecatedBadge
Obsolete
Experimental

This prevents the <i> tag from being concatenated. (The closing tag is not removed as I stared in Comment 1)

Comment 4

[David Walsh :davidwalsh]

Can someone provide a screenshot of the issue?  I'm not seeing it now.  Thanks!

Comment 5

[Jean-Yves Perrier [:teoli]]

Sure. You can see it on: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date

By doing a shift reload on https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/prototype and https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date the problem will go away.

I'm attaching the screenshot.

Comment 6

[Jean-Yves Perrier [:teoli]]

Attachment: Screen Shot 2013-09-16 at 15.02.23.png

Comment 7

[David Walsh :davidwalsh]

Ahh, OK, so this is a template CSS issue, not a redesign issue. I'm seeing 2 "<i>" elements here.  I'll let you designers work it out, but let me know if you need help.

Comment 8

[Jean-Yves Perrier [:teoli]]

Yes, not related to the redesign :-)

We have a work-around and will think about a proper solution once we have launched the beta :-)

Comment 9

[Florian Scholz (Open Web Docs)]

The pages mentioned here have been cleaned-up. For issues with the {{page}} macro, see bug 834055.