Integrate adb helper addon into the app manager

RESOLVED FIXED in Firefox 26

Status

RESOLVED FIXED
6 years ago
8 months ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

unspecified
Firefox 26
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 803054 [details]
adbhelper@mozilla.org.xpi

So far, you had to manually install and run adb forward command to make the app manager connect to a device. But thanks to the work being done in the simulator addon, we can ship an helper addon in order to ship adb (not the whole android SDK) and run this command automagically for the user.

I started crafting such helper addon here:
https://github.com/ochameau/adbhelper
And I'm attaching an xpi to this bug.
(Assignee)

Comment 1

6 years ago
Created attachment 803056 [details] [diff] [review]
Add a JSM to allow addons to register devices to the app manager
(Assignee)

Comment 2

6 years ago
Created attachment 803058 [details] [diff] [review]
code example for the UI

And here is an (working) example to see how we could potentialy use this JSM from the UI.
(Assignee)

Updated

6 years ago
Attachment #803056 - Flags: review?(paul)
Comment on attachment 803056 [details] [diff] [review]
Add a JSM to allow addons to register devices to the app manager

Can you rebase moz.build on fx-team?
Attachment #803056 - Flags: review?(paul) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 803083 [details] [diff] [review]
JSM - rebased against fx-team
Attachment #803056 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #803083 - Flags: review+

Updated

6 years ago
Blocks: 912913

Updated

6 years ago
Blocks: 915740

Updated

6 years ago
No longer blocks: 915740
Keywords: checkin-needed
Whiteboard: [land-in-fx-team]

Updated

6 years ago
Blocks: 915740

Updated

6 years ago
Attachment #803083 - Flags: review+ → review+
Attachment #803058 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/662396e19e60

FYI, you don't need to use [land-in-fx-team] anymore. Just checkin-needed works fine :)
Assignee: nobody → poirot.alex
Keywords: checkin-needed
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/662396e19e60
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26

Updated

8 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.