Closed Bug 915204 Opened 6 years ago Closed 6 years ago

Integrate adb helper addon into the app manager

Categories

(DevTools :: WebIDE, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(2 files, 2 obsolete files)

So far, you had to manually install and run adb forward command to make the app manager connect to a device. But thanks to the work being done in the simulator addon, we can ship an helper addon in order to ship adb (not the whole android SDK) and run this command automagically for the user.

I started crafting such helper addon here:
https://github.com/ochameau/adbhelper
And I'm attaching an xpi to this bug.
Attached patch code example for the UI (obsolete) — Splinter Review
And here is an (working) example to see how we could potentialy use this JSM from the UI.
Attachment #803056 - Flags: review?(paul)
Comment on attachment 803056 [details] [diff] [review]
Add a JSM to allow addons to register devices to the app manager

Can you rebase moz.build on fx-team?
Attachment #803056 - Flags: review?(paul) → review+
Attachment #803056 - Attachment is obsolete: true
Attachment #803083 - Flags: review+
Blocks: appmgr_v1
Blocks: 915740
No longer blocks: 915740
Keywords: checkin-needed
Whiteboard: [land-in-fx-team]
Blocks: 915740
Attachment #803058 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/662396e19e60

FYI, you don't need to use [land-in-fx-team] anymore. Just checkin-needed works fine :)
Assignee: nobody → poirot.alex
Keywords: checkin-needed
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/662396e19e60
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.