Closed Bug 915236 Opened 7 years ago Closed 7 years ago

Do not turn screen on for Email notifications

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set

Tracking

(blocking-b2g:koi+, b2g-v1.2 verified)

RESOLVED FIXED
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- verified

People

(Reporter: pdol, Assigned: mikehenrty)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

Currently all notifications force the screen to turn on regardless of the notification type.  A longer term fix for programmatic control over the screen turning on will be pursued, but for 1.2 Email notifications should not force the screen on.  This is due to concerns about user annoyance and battery drain for users with large email volumes.
Whiteboard: [systemsfe]
Attachment #803676 - Flags: review?(kyle) → review+
Michael Henretty changed story state to started in Pivotal Tracker
9271176b1fc4760fb2ecda8635a6f00ae4df6182
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Gregor Wagner changed story state to finished in Pivotal Tracker
Keywords: verifyme
QA Contact: jsmith
Verified Fixed on Buri Moz Ril 

Environmental Variables
Build ID: 20130925004005
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/fb764e648a8f
Gaia: b0e4a1333bb7bf0a749a384ba99e4f03f111e39a
Platform Version: 26.0a2

The device does not power on upon email notification
Keywords: verifyme
Jason Smith changed story state to delivered in Pivotal Tracker
Jason Smith changed story state to accepted in Pivotal Tracker
Attachment mime type: text/plain → text/x-github-pull-request
This bug915236 change has affected the cell broadcast receiving, reading, delete all, and in system/js/notification.js:
     if (detail.manifestURL.indexOf('email.gaiamobile.org') === -1)   //line 374
     it return an Error here: 06-24 14:44:48. 509, 111, 111 E GeckoConsole: [JavaScript Error: "TypeError: detail. ManifestURL is undefined" {file: "app://system.gaiamobile.org/js/notifications.js" line: 374}].
     Cell broadcast received ,read and delete all normal after I changed it in local,  please help to land the patch to V1.4. 
     Thank you very much ! Because time emergency
Attachment #8449149 - Flags: review?(ferjmoreno)
Flags: needinfo?(mhenretty)
Comment on attachment 8449149 [details] [diff] [review]
Bug326683_cell_broadcast_can't_read_and_clearAll_in_lockscreen.patch

Hi :Shufang.Xu,

Thanks for your patch. The fix looks good to me, but I'd like to hear Michael's feedback as he wrote the original patch. Do we still need to do this check for the email app?

Also, could you file a follow-up bug, attach this patch to it and nominate it for 1.4, please?
Attachment #8449149 - Flags: review?(ferjmoreno) → feedback+
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #9)
> Comment on attachment 8449149 [details] [diff] [review]
> Bug326683_cell_broadcast_can't_read_and_clearAll_in_lockscreen.patch
> 
> Hi :Shufang.Xu,
> 
> Thanks for your patch. The fix looks good to me, but I'd like to hear
> Michael's feedback as he wrote the original patch. Do we still need to do
> this check for the email app?
> 
> Also, could you file a follow-up bug, attach this patch to it and nominate
> it for 1.4, please?

   I suggest to check the best, when mail received, whether the phone's screen will light screen. Whether this function is affected. I generated  the patch in V1.4.
   Thank you very much!
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #9)
> Comment on attachment 8449149 [details] [diff] [review]
> Bug326683_cell_broadcast_can't_read_and_clearAll_in_lockscreen.patch
> 
> Hi :Shufang.Xu,
> 
> Thanks for your patch. The fix looks good to me, but I'd like to hear
> Michael's feedback as he wrote the original patch. Do we still need to do
> this check for the email app?
> 
> Also, could you file a follow-up bug, attach this patch to it and nominate
> it for 1.4, please?

  Now,should I file a new bug about the problem immediately?Or wait you confirm? please reply it to me,Thank you very much!
(In reply to Shufang.Xu from comment #11)
> (In reply to Fernando Jiménez Moreno [:ferjm] from comment #9)
> > Comment on attachment 8449149 [details] [diff] [review]
> > Bug326683_cell_broadcast_can't_read_and_clearAll_in_lockscreen.patch
> > 
> > Hi :Shufang.Xu,
> > 
> > Thanks for your patch. The fix looks good to me, but I'd like to hear
> > Michael's feedback as he wrote the original patch. Do we still need to do
> > this check for the email app?
> > 
> > Also, could you file a follow-up bug, attach this patch to it and nominate
> > it for 1.4, please?
> 
>   Now,should I file a new bug about the problem immediately?Or wait you
> confirm? please reply it to me,Thank you very much!
Flags: needinfo?(ferjmoreno)
(In reply to Shufang.Xu from comment #11)
> (In reply to Fernando Jiménez Moreno [:ferjm] from comment #9)
> > Comment on attachment 8449149 [details] [diff] [review]
> > Bug326683_cell_broadcast_can't_read_and_clearAll_in_lockscreen.patch
> > 
> > Hi :Shufang.Xu,
> > 
> > Thanks for your patch. The fix looks good to me, but I'd like to hear
> > Michael's feedback as he wrote the original patch. Do we still need to do
> > this check for the email app?
> > 
> > Also, could you file a follow-up bug, attach this patch to it and nominate
> > it for 1.4, please?
> 
>   Now,should I file a new bug about the problem immediately?Or wait you
> confirm? please reply it to me,Thank you very much!

Yes please file a new bug. This one is already resolved fixed and we shouldn't add new patches to a closed bug.
What Gregor said :).

You should file a new bug, attach your patch to the new bug and ask for feedback there.
Flags: needinfo?(ferjmoreno)
See bug 1033889 comment 5.
Depends on: 1033889
Flags: needinfo?(mhenretty)
You need to log in before you can comment on or make changes to this bug.