Tracelogger: Add logging of background gc thread

RESOLVED FIXED in mozilla27

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: h4writer, Assigned: h4writer)

Tracking

unspecified
mozilla27
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 803107 [details] [diff] [review]
bug915244-tracelogger-gc-thread

- Removes loggingTime since that doesn't work to combine multiple threads logging. 
- Adds logging of gc background thread.
Assignee: general → hv1989
Attachment #803107 - Flags: review?(till)
(Assignee)

Comment 2

5 years ago
Comment on attachment 803107 [details] [diff] [review]
bug915244-tracelogger-gc-thread

Review of attachment 803107 [details] [diff] [review]:
-----------------------------------------------------------------

@Terrence: just sanity check if I'm logging the right bits ;)
Attachment #803107 - Flags: feedback?(terrence)
Comment on attachment 803107 [details] [diff] [review]
bug915244-tracelogger-gc-thread

Review of attachment 803107 [details] [diff] [review]:
-----------------------------------------------------------------

Yup!

::: js/src/jsgc.cpp
@@ +2336,3 @@
>              break;
>            case CANCEL_ALLOCATION:
>              state = IDLE;

Don't you need to log GC_ALLOCATING_STOP here, too?
Attachment #803107 - Flags: review?(till) → review+
Comment on attachment 803107 [details] [diff] [review]
bug915244-tracelogger-gc-thread

Review of attachment 803107 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine with Till's comment added.

As a general note, it might be worth giving the loggers JS_ALWAYS_INLINE bodies and making them empty in non JS_TRACE_LOGGING builds. Would allow you to remove all the #if scattered about.
Attachment #803107 - Flags: feedback?(terrence) → feedback+
https://hg.mozilla.org/mozilla-central/rev/2a7318d2b99c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.