915245 - Add manifest support to cpp unittest harness

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Dan Minor [:dminor]]

When running the cpp unittests on Android, there are a small number of consistent failures. 

Adding a simple manifest file to the harness would allow these to be skipped until they are resolved. A list of filenames to be skipped would be sufficient for this purpose and I don't seen an immediate need for anything more sophisticated.

Comment 1

[Dan Minor [:dminor]]

Attachment: Patch to add manifest support and stage manifest file in test package.

Try runs here:
https://tbpl.mozilla.org/?tree=Try&rev=e936924251e0
https://tbpl.mozilla.org/?tree=Try&rev=15081ccb3648

I'll file bugs for the skipped tests, but I usually hold off until things are running on Cedar just to make sure results there match what I see locally.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 803733 [details] [diff] [review]
Patch to add manifest support and stage manifest file in test package.

Review of attachment 803733 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/runcppunittests.py
@@ +131,5 @@
>                          action = "store", type = "string", dest = "symbols_path",
>                          default = None,
>                          help = "absolute path to directory containing breakpad symbols, or the URL of a zip file containing symbols")
> +        self.add_option("--manifest-file",
> +                        action = "store", type = "string", dest = "manifest_file",

Maybe we should make this more specific and call it --skip-manifest or something like that?

@@ +142,2 @@
>      progs = []
> +    skipped_progs = []

I'd use a set() here, but for the size of the skipped list it's not going to make a huge difference.

Comment 3

[Dan Minor [:dminor]]

Thanks, with comments addressed: https://hg.mozilla.org/integration/mozilla-inbound/rev/3934868da81e

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3934868da81e