Closed
Bug 915341
Opened 11 years ago
Closed 11 years ago
make slaveapi packageable/installable
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(1 file)
3.77 MB,
patch
|
jhopkins
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
It'll be much easier to deploy properly if it's installable through pip. Some notes about this patch: * I've removed the vendor library because PuppetAgain handles both compiled and pure python dependencies without issue -- there's no need to embed it in the repository anymore. This also means we don't need the requirements/ directory anymore, as those have moved into setup.py. * Existing content has been moved from slaveapi/__init__.py to global_state.py so that setup.py can import the version without requiring things like gevent be installed already. * Pidfile is now defined in the .ini and the sample file uses absolute paths. This is mostly a UX thing because after pip installing slaveapi, slaveapi-server.py will be in $PATH. Given that, I didn't think it made sense to assume that the pid, log, and credentials.json are in a particular place.
Attachment #803225 -
Flags: review?(jhopkins)
Updated•11 years ago
|
Attachment #803225 -
Flags: review?(jhopkins) → review+
Assignee | ||
Comment 1•11 years ago
|
||
Comment on attachment 803225 [details] [diff] [review] make slaveapi installable Merged and pushed.
Attachment #803225 -
Flags: checked-in+
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Component: Tools → General
You need to log in
before you can comment on or make changes to this bug.
Description
•