Closed Bug 915353 Opened 6 years ago Closed 6 years ago

Add uk and ro to the multilocale Fennec build for Firefox 25

Categories

(Firefox for Android :: General, defect)

25 Branch
x86
macOS
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 25
Tracking Status
firefox25 + verified
relnote-firefox --- 25+

People

(Reporter: gueroJeff, Assigned: gueroJeff)

References

Details

Attachments

(1 file)

Please add uk and ro to mozilla-aurora/mobile/android/locales/maemo-locales to include it in the multi-locale APK for Firefox 25.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or IDL/UUID changes made by this patch:
Attachment #803252 - Flags: review?(mark.finkle)
Attachment #803252 - Flags: checkin?(l10n)
Attachment #803252 - Flags: approval-mozilla-aurora?
Blocks: 890723
Depends on: 914356
Attachment #803252 - Flags: review?(mark.finkle) → review+
We are good to go. Land away!
Comment on attachment 803252 [details] [diff] [review]
Adds signed off ro and uk to multilocale builds of Firefox 25 after ga-IE has been added.

Approving for Aurora, assuming this is the same situation as bug 914356 (can't land to m-c)
Attachment #803252 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: in-moztrap?(fennec)
Thanks all from Romanian team! :)
Comment on attachment 803252 [details] [diff] [review]
Adds signed off ro and uk to multilocale builds of Firefox 25 after ga-IE has been added.

https://hg.mozilla.org/releases/mozilla-aurora/rev/9ac5332eb426, landed on aurora.
Attachment #803252 - Flags: checkin?(l10n) → checkin+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee: nobody → jbeatty
Target Milestone: --- → Firefox 25
(In reply to Alex Keybl [:akeybl] from comment #3)
> Comment on attachment 803252 [details] [diff] [review]
> Adds signed off ro and uk to multilocale builds of Firefox 25 after ga-IE
> has been added.
> 
> Approving for Aurora, assuming this is the same situation as bug 914356
> (can't land to m-c)

Thanks Alex. There are only a handful of locales that work on central and tend to be the exception rather than the rule. I'll be sure to note this on future approval bugs.
Test cases added in moztrap:
ro: https://moztrap.mozilla.org/manage/case/10184/
uk: https://moztrap.mozilla.org/manage/case/9703/
Flags: in-moztrap?(fennec) → in-moztrap+
Verified fixed on:
Build: Firefox for Android 25.0b1 (2013-09-18)
Device: Samsung Galaxy R
OS: Android 2.3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.