Allow liking on search result tiles

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Jacob, Assigned: Tanay)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
I find it far easier to like something straight from the search result tile than by opening up the make and pulling down the details section.

I guess there was a discussion on this already, but I would be interested in liking makes straight from the tiles themselves. Right now you can only do it for featured makes on the homepage, /teach, or /starter-makes

Comment 1

5 years ago
Please assign this bug to me
(Reporter)

Comment 2

5 years ago
Go get 'em tiger!
Assignee: nobody → zak.hassan1010

Comment 3

5 years ago
@Jacob

I don't see any tiles on the homepage. When I click on gallery I see the tiles with "Like" already implemented.
(Reporter)

Comment 4

5 years ago
@Zakeria what I'm referring to are the tiles after you do a search. 

Go to http://webmaker.org/search and enter a term. Notice how the tiles have no empty hearts.

Adding a needinfo flag for Kate because I'm not entirely positive she wants this in the UX design, but I think it would be good to like things from search without having to open them. Often you see things related to the project you want to find that you just feel like giving a heart on the spot.
Flags: needinfo?(kate)
Yeah I agree, it would be cool to have liking on those tiles. Let's do it!
Flags: needinfo?(kate)
(Assignee)

Comment 6

5 years ago
I would like to work on this bug, please give some guidance as to which components need to be modified...
Flags: needinfo?(kate)
Comment on attachment 8459646 [details] [diff] [review]
https://github.com/mozilla/webmaker.org/pull/905

One comment in the js
Attachment #8459646 - Flags: review?(kate) → review-
Flags: needinfo?(kate)
(Assignee)

Updated

5 years ago
Attachment #8459646 - Flags: review- → review?(kate)
Did you make a new PR somewhere? this one appears to be closed
Flags: needinfo?(tanay1337)
(Assignee)

Comment 10

5 years ago
Needed help with the PR, build was not passing, will open one ASAP.
Flags: needinfo?(tanay1337)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Oops closed the wrong ticket
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 12

4 years ago
Comment on attachment 8459646 [details] [diff] [review]
https://github.com/mozilla/webmaker.org/pull/905

https://github.com/mozilla/webmaker.org/pull/905
Attachment #8459646 - Attachment description: https://github.com/mozilla/webmaker.org/pull/892 → https://github.com/mozilla/webmaker.org/pull/905
Attachment #8459646 - Attachment is patch: true
Attachment #8459646 - Attachment mime type: text/x-github-pull-request → text/plain
Comment on attachment 8459646 [details] [diff] [review]
https://github.com/mozilla/webmaker.org/pull/905

Almost - you just need to change the order of the placement of "localized" in require
Attachment #8459646 - Flags: review?(kate) → review-
(Assignee)

Updated

4 years ago
Attachment #8459646 - Flags: review- → review?(kate)

Updated

4 years ago
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Assignee: zak.hassan1010 → tanay1337
You need to log in before you can comment on or make changes to this bug.