91539 - baseURI property wrong type

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Ok, this is a regression. At some point baseURI property (for XML at least)
changed type from string to something else. 

To check this out, open the URL, select Bookmark This Link from the context menu
for some link in the testcase. Instead of the URL you will see something like
this in the dialog that pops up:

[xpconnect wrapped nsIURI @ 0x4e96050]

Comment 1

[Boris Zbarsky [:bzbarsky]]

http://lxr.mozilla.org/seamonkey/source/dom/public/idl/core/nsIDOMNode.idl#91
says:

readonly attribute DOMString        baseURI;

The real problem is in
http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/nsContextMenu.js#677
and/or its callers.  The function returns:

var baseURI  = ioService.newURI(base, null);
return ioService.newURI(baseURI.resolve(url), null);

This returns an nsIURI instead of a string, of course.  Jst, did the ToString()
method recently change for any nsIURI implementations?

Looking at the code, all the callers of makeURLAbsolute want a string, not an
nsIURI.  Over to XP Apps:GUI.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: proposed patch

Comment 3

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Looks ok to me, r=heikki. I think dougt broke this. Our XML support has suffered
some serious regressions lately :(

Comment 4

[Johnny Stenback (:jst)]

I don't remember hearing anything about changes to nsIURI except for the dougt
changes that landed maybe a month ago or so. I don't think we ever had a
toString() method in nsIURI.

Comment 5

[Blake Ross]

Looks fine. sr=blake

Heikki, can you check this in?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Checked in

Comment 7

[sairuh (rarely reading bugmail)]

vrfy fixed [although Bookmark This Link is now File Bookmark for Link]. now see
the proper URL in the Location field in the resulting dialog.

linux and mac, 2001.08.15.08-comm
winnt, 2001.08.15.06-comm

Comment 8

[sairuh (rarely reading bugmail)]

oops, for linux-comm builds tested: s/2001.08.15.08/2001.08.15.14