Closed Bug 915479 Opened 8 years ago Closed 7 years ago

IonMonkey: MPassArg shouldn't be typed with the argument type of its argument in IonBuilder

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: bbouvier, Assigned: jandem)

References

Details

(Whiteboard: [qa-])

This began to blow up with Float32: if an MPassArg is typed as Double during Ion building, but then its real argument is specialized to Float32 during ApplyTypes, there won't be a conversion from Float32 to Double and the receiving function will receive a Float32 argument while it expects a Double. BOOM.

An example of such a case happens in bug 915301. The fix proposed there should be temporary, and IMO we should fix MPassArg instead.
Fixed by Bug 952992.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee: general → jdemooij
Depends on: 952992
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.