Closed Bug 915485 Opened 6 years ago Closed 6 years ago

Async scripts parsed with !options.compileAndGo with off-main-thread parsing

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: luke, Assigned: bhackett)

References

Details

Attachments

(1 file)

When scripts are parsed off the main thread, it seems options.compileAndGo is false.  This effectively disables Ion and Odin compilation on these scripts which slaughters performance of, e.g., unrealengine.com/html5.
Attached patch patchSplinter Review
Whoops.
Assignee: general → bhackett1024
Attachment #803907 - Flags: review?(luke)
Comment on attachment 803907 [details] [diff] [review]
patch

Awesome.  Tested on Citadel and BananaBench and no jank.  Nice work!
Attachment #803907 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/5b89a959713b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.