Async scripts parsed with !options.compileAndGo with off-main-thread parsing

RESOLVED FIXED in mozilla26

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: luke, Assigned: bhackett)

Tracking

unspecified
mozilla26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
When scripts are parsed off the main thread, it seems options.compileAndGo is false.  This effectively disables Ion and Odin compilation on these scripts which slaughters performance of, e.g., unrealengine.com/html5.
(Assignee)

Comment 1

5 years ago
Created attachment 803907 [details] [diff] [review]
patch

Whoops.
Assignee: general → bhackett1024
Attachment #803907 - Flags: review?(luke)
(Reporter)

Comment 2

5 years ago
Comment on attachment 803907 [details] [diff] [review]
patch

Awesome.  Tested on Citadel and BananaBench and no jank.  Nice work!
Attachment #803907 - Flags: review?(luke) → review+

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5b89a959713b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.