915506 - AeroPeek not fully disabled in multi-process browser

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

One attempt to use AeroPeek is disabled in multi-process browsers, but another is not.  This patch disables it in both cases.  Without this patch, the console will report:

chrome://mochitests/content/browser/toolkit/components/social/test/browser/browser_workerAPI.js | uncaught exception - TypeError: win.gTaskbarTabGroup is undefined at resource:///modules/WindowsPreviewPerTab.jsm:678

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-915506-ensure-AeroPeek-is-fully-disabled-with-e1.patch

This patch ensures all attempts to use |Win7Features| in browser.js will be disabled in multi-process browsers.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/d45a33d0fc2e

Comment 3

[Dão Gottwald [:dao]]

This patch is backwards, it makes Win7Features null in non-e10s builds.

Backed out:
https://hg.mozilla.org/integration/fx-team/rev/23708fab4a39

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-915506-ensure-AeroPeek-is-fully-disabled-with-e1.patch

Sorry about that - I'm obviously having a bad afternoon :(

Comment 5

[Mark Hammond [:markh] [:mhammond]]

0002-Bug-915511-prevent-SessionStore.getWindowValue-faili.patch

Comment 6

[Mark Hammond [:markh] [:mhammond]]

*sob* - I think it's time to stop for the day

https://hg.mozilla.org/integration/fx-team/rev/1f8240fcc47a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1f8240fcc47a