915508 - simultaneous build directories are weirdly separated in the status line

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

When there are several directories built at the same time, the mach status line looks like:
TIER: foo bar SUBTIER: baz qux hoge DIRECTORIES: 1/42 (dir1 ,dir2)

(note the order between the space and the comma)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Change the order of space and comma in the mach status line when several directories are built at the same time

Comment 2

[Mike Hommey [:glandium]]

Attachment: Change the order of space and comma in the mach status line when several directories are built at the same time

While here, when there is no active_dirs, it would print ')' alone, fixed that to be '()'.

Comment 3

[Mike Hommey [:glandium]]

Note it's also weird looking when there are several subtiers built at the same time, in which case, it looks like:
TIER: foo bar SUBTIER: baz qux hoge DIRECTORIES: 1/42 (dir1 ,dir2)2/13 (dir3 ,dir4)
It also doesn't seem to eliminate finished subtiers, although that due be related to bug 915535:
TIER: foo bar SUBTIER: baz qux hoge DIRECTORIES: 21/42 (dir1 ,dir2)13/13 ()

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 803527 [details] [diff] [review]
Change the order of space and comma in the mach status line when several directories are built at the same time

Review of attachment 803527 [details] [diff] [review]:
-----------------------------------------------------------------

Itertools makes my head hurt. I'm mixed about people discovering its awesomeness :)

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/79d504af18f6

Comment 6

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/mozilla-central/rev/79d504af18f6