Closed Bug 915508 Opened 6 years ago Closed 6 years ago

simultaneous build directories are weirdly separated in the status line

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file, 1 obsolete file)

When there are several directories built at the same time, the mach status line looks like:
TIER: foo bar SUBTIER: baz qux hoge DIRECTORIES: 1/42 (dir1 ,dir2)

(note the order between the space and the comma)
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
While here, when there is no active_dirs, it would print ')' alone, fixed that to be '()'.
Attachment #803527 - Flags: review?(gps)
Attachment #803498 - Attachment is obsolete: true
Attachment #803498 - Flags: review?(gps)
Note it's also weird looking when there are several subtiers built at the same time, in which case, it looks like:
TIER: foo bar SUBTIER: baz qux hoge DIRECTORIES: 1/42 (dir1 ,dir2)2/13 (dir3 ,dir4)
It also doesn't seem to eliminate finished subtiers, although that due be related to bug 915535:
TIER: foo bar SUBTIER: baz qux hoge DIRECTORIES: 21/42 (dir1 ,dir2)13/13 ()
Comment on attachment 803527 [details] [diff] [review]
Change the order of space and comma in the mach status line when several directories are built at the same time

Review of attachment 803527 [details] [diff] [review]:
-----------------------------------------------------------------

Itertools makes my head hurt. I'm mixed about people discovering its awesomeness :)
Attachment #803527 - Flags: review?(gps) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/79d504af18f6
Component: mach → Build Config
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/79d504af18f6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.