Closed Bug 915511 Opened 6 years ago Closed 6 years ago

SessionStore.getWindowValue fails in multi-process browser.

Categories

(Firefox :: Session Restore, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 26

People

(Reporter: markh, Assigned: markh)

References

Details

Attachments

(1 file)

browser-tabview.js calls SessionStore.getWindowValue(), which fails in multi-process browsers.  This patch causes it to return an empty string instead, which allows the browser startup process to complete without errors.
This patch causes getWindowValue to return an empty string if the session store is disabled for e10s.
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Attachment #803499 - Flags: review?(felipc)
Comment on attachment 803499 [details] [diff] [review]
0002-Bug-915511-prevent-SessionStore.getWindowValue-faili.patch

In keeping the same pattern as this property is used elsewhere, add this check at the beginning of the function
Attachment #803499 - Flags: review?(felipc) → review+
What exactly makes getWindowValue() fail in a multi-process browser? What is the STR of the issue here?

I don't really like having _disabledForMultiProcess sprinkled everywhere and it seems like we shouldn't need to do this for per-window values, no?

(Also, a little note would have been appreciated before adding stuff to SessionStore, we're working hard on rewriting quite a lot of it right now :)
Sorry Tim, I totally forgot this was being worked on at the moment - I should have asked you for review.

The STR is to enable e10s - but sadly the exception is swallowed (have I mentioned my thoughts on promises recently ;)  As this is at the very end of the delayed startup code, the impact isn't obvious - but it causes tests to fail to start as line 1303 of browser.js is never reached.

Basically, http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#1301 fails - browser-tabview ends up calling getWindowValue().  I figured that as SessionStore already has workarounds for e10s it was probably better than catching the exception higher and rethrowing.

I'm happy to adjust this as you request.
https://hg.mozilla.org/mozilla-central/rev/7f4cecc6b53c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.