Closed Bug 915551 Opened 10 years ago Closed 10 years ago

Make text-align apply on ::-moz-placeholder

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: eliaspizarro, Assigned: mounir)

References

(
URL
)

Details

(Keywords: dev-doc-needed, Whiteboard: [DocArea=CSS])

Attachments

(2 files)

bug
37.14 KB, image/jpeg
Details
Patch
2.06 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Attached image bug — 
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130814063812

Steps to reproduce:

create a input box
<input id="test" placeholder="test!">

add an css style
:-moz-placeholder { text-align:center; } /*FF Old*/
::-moz-placeholder { text-align:center; } /*FF19+*/
::-webkit-input-placeholder{ text-align:center; } /*Chrome*/
:-ms-input-placeholder{ text-align:center; } /*IE10*/


Actual results:

doesn't work, the placeholder appears at left.


Expected results:

 the placeholder should be appear centered.
URL: http://jsfiddle.net/eliaspizarro/ze4fV/
Priority: -- → P1
The text-align property isn't marked as applying to the placeholder.  Maybe it should be?
Component: CSS Parsing and Computation → Layout: Form Controls
Flags: needinfo?(dbaron)
Priority: P1 → --
Seems reasonable.  A spec would be nice, though.
Flags: needinfo?(dbaron)
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86_64 → All
Summary: Can't get placeholder centered with moz-placeholder → Make text-align apply on ::-moz-placeholder
Version: 23 Branch → Trunk
Attached patch Patch — — Splinter Review 
This should allow setting text-align on ::-moz-placeholder.

It would be great if this could be pushed after being reviewed given that I am going to be 100% offline for a week in a few hours.

Try push:
https://tbpl.mozilla.org/?tree=Try&rev=c0c8cd4da843
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #804445 - Flags: review?(bzbarsky)
Flags: in-testsuite+
Comment on attachment 804445 [details] [diff] [review]
Patch

r=me
Attachment #804445 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/64b97a7ea15b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Whiteboard: [DocArea=CSS]
You need to log in before you can comment on or make changes to this bug.