915551 - Make text-align apply on ::-moz-placeholder

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[eliaspizarro]

Attachment: bug

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130814063812

Steps to reproduce:

create a input box
<input id="test" placeholder="test!">

add an css style
:-moz-placeholder { text-align:center; } /*FF Old*/
::-moz-placeholder { text-align:center; } /*FF19+*/
::-webkit-input-placeholder{ text-align:center; } /*Chrome*/
:-ms-input-placeholder{ text-align:center; } /*IE10*/


Actual results:

doesn't work, the placeholder appears at left.


Expected results:

 the placeholder should be appear centered.

Comment 1

[Boris Zbarsky [:bzbarsky]]

The text-align property isn't marked as applying to the placeholder.  Maybe it should be?

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Seems reasonable.  A spec would be nice, though.

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Patch

This should allow setting text-align on ::-moz-placeholder.

It would be great if this could be pushed after being reviewed given that I am going to be 100% offline for a week in a few hours.

Try push:
https://tbpl.mozilla.org/?tree=Try&rev=c0c8cd4da843

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 804445 [details] [diff] [review]
Patch

r=me

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/64b97a7ea15b