Closed Bug 915573 Opened 7 years ago Closed 7 years ago

[Dialer] Mobile type is not shown in the dialer screen for contacts with custom tags for phone number

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

VERIFIED FIXED
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: isabelrios, Assigned: etienne)

References

Details

(Keywords: regression, Whiteboard: [u=commsapps-user c=contacts p=0])

Attachments

(3 files)

Attached image 1980-01-12-23-21-16.png
Master 09/12 build.
Gecko-729cc01
Gaia-70800e3

STR
From another device send a contact with Name and Phone Number via Bluetooth to DuT.
1. Tap on the File review request
2. Accept the transfer
3. Once the contact is shown correctly in the contact list, tap on it.
4. On the contact's details screen tap on the phone number to start the call

EXPECTED
When tapping on the phone number, the dialer is open with the contact's name, mobile type and number.

ACTUAL
Mobile type info is missing, so the info presented in the dialer is not correct. 
Instead of Mobile, 123456789, it appears: , 123456789.

Please see screenshot attached
Blocks: 915254
I've tested this, and is reproducible when the imported phone comes with a custom type -that is, one type that is not part of the basic ones we support ['mobile','home', 'work', 'personal', 'faxHome', 'faxOffice', 'faxOther', 'another']

Android phones, for example, use the phone type CELL.

This can be also reproducible if we create a contact on the FFOS device and apply a custom tag to the phone type. When we try to call that phone, we'll see the same " , 123456789".

I'm afraid that this has nothing to do with bluetooth or exporting/importing, but with the way we handle custom tags on Dialer, or the way that Contacts provide the information (but as SMS deals properly with custom tags, I think it has more to do with Dialer). Pinging German for more info
Flags: needinfo?(gtorodelvalle)
Fernando is completely right ;-) In fact, the problem is the inclusion of a custom tag which is not expected :p by the code as you can see here: https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/utils.js#L83 When using custom tags that code asks the localization service to translate something which should not be translated. Obviously, the simplest solution is to just show the type when is it a custom one (do not translate), which means it has not any of the following values: mobile, home, work, personal, faxHome, faxOffice, faxOther, another.

I'll take it as soon as I have some time ;-) Anyhow, feel free to take it since the solution is straight-forward :-P
Flags: needinfo?(gtorodelvalle)
triage: not block a release but please ask for approval for landing into v1.2 when you have a fix.
blocking-b2g: koi? → ---
Attached image Bug_915573_v1.0.1.png
Custom tags are properly working in v1.0.1, notice that the issue also appears when creating a contact manually and adding a custom field. Since it is a regression, asking for koi? again.
blocking-b2g: --- → koi?
triage: regression. koi+
blocking-b2g: koi? → koi+
Keywords: regression
Renaming after comment 1 and confirmation on comment 2
Component: Gaia::Contacts → Gaia::Dialer
Summary: [Contacts] Mobile type is not shown in the dialer screen for contacts received via bluetooth → [Dialer] Mobile type is not shown in the dialer screen for contacts with custom tags for phone number
Assignee: nobody → etienne
Attached file Pointer to gaia PR
Showing the custom type string untranslated when we don't have a translation.
Attachment #812697 - Flags: review?(anthony)
Comment on attachment 812697 [details]
Pointer to gaia PR

Patch looks ok. In the tests, I think using a stub that returns an empty string would be more expressive.
Attachment #812697 - Flags: review?(anthony) → review-
Comment on attachment 812697 [details]
Pointer to gaia PR

Updated!
Attachment #812697 - Flags: review- → review?(anthony)
Comment on attachment 812697 [details]
Pointer to gaia PR

Glop! Glop!
Attachment #812697 - Flags: review?(anthony) → review+
https://github.com/mozilla-b2g/gaia/commit/b6177f2ffd949c5b71b141d911cf572b10848493
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Uplifted b6177f2ffd949c5b71b141d911cf572b10848493 to:
v1.2: b9c5604342e024c42fb9cee97cab3953a9377f22
Hi, 
Tried to verify this bug, but adding a custom tag as mobile type does not work. 
When tapping on Mobile, the label list is shown, it is possible to tap on Custom field and type anything but when tapping on Done, the custom label written is discarded. Only changing to a default labels defined works.

This is a regression, could this be related to the patch or a new bug should be open?
Thanks
Checked with 10/09 v1.2 build:
Gecko-bd1bd24
Gaia-1499c58
> This is a regression, could this be related to the patch or a new bug should
> be open?

I had the issue before writing the patch in order to reproduce the bug I had to "hard code" a custom type in one of my contact.

A new bug should be open. Sorry I didn't do it myself.
(In reply to Etienne Segonzac (:etienne) from comment #15)
> > This is a regression, could this be related to the patch or a new bug should
> > be open?
> 
> I had the issue before writing the patch in order to reproduce the bug I had
> to "hard code" a custom type in one of my contact.
> 
> A new bug should be open. Sorry I didn't do it myself.

Thanks Etienne, I will open it then.
> 
> A new bug should be open. Sorry I didn't do it myself.

Fyi, bug already filed, Bug 924903
Verified on 11/18 v1.2 build: 
Gecko-1443247
Gaia-7a23f8c
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.