915582 - [Music] Handle errors when the music player is unable to play some files

Status: RESOLVED DUPLICATE of bug 1149930

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Dominic Kuo [:dkuo]]

In music app, our strategy to distinguish the playable and unplayable files is filtering them while parsing the metadata, this should works for most of the files but not all of them.

For those files that we can cannot recognize them are unplayable, and displayed on the ui, like corrupted files or files that can break the audio(decoder), we should handle them and probably have some ui to tell users that the player has encountered some problems, or auto skip them to the next track.

This will need some UX inputs for sure, Rob, can you please comment on this? thanks.

Comment 1

[Tiffanie Shakespeare [:tif]]

Hi Dominic! I'm helping Rob out with this bug. I have a few questions:

1) when you say "break the audio (decoder)" are you referring to DRM protected files?
2) can we tell the difference between a corrupted file and the one that breaks the decoder?

Also, how does the phone currently handle these files? From my experiments with the simulator, it seems that corrupted files immediately stop playing and go back a screen. The files I downloaded from iTunes (DRM protected I'm assuming) don't play but nothing else happens in the UI either. Is this what I should be experiencing?

Thanks for the info!

Comment 2

[Dominic Kuo [:dkuo]]

(In reply to Tiffanie Shakespeare from comment #1)
> Hi Dominic! I'm helping Rob out with this bug. I have a few questions:

Good to know you are working on this!

> 1) when you say "break the audio (decoder)" are you referring to DRM
> protected files?

No, if it's a DRM protected file, currently music has the capability to identify it before play it. I am referring to those audio files that after music app started to play them, they might cause unknown errors by some reasons, and music can only handle them when the errors occur.

> 2) can we tell the difference between a corrupted file and the one that
> breaks the decoder?

I am not 100% sure but I think the answer is no. It make sense that, a corrupted file and a file caused decode error reported the same error code, because they all result in "unplayable". I guess there are more error codes so I will read the spec and see how many error conditions we got.

> Also, how does the phone currently handle these files? From my experiments
> with the simulator, it seems that corrupted files immediately stop playing
> and go back a screen. The files I downloaded from iTunes (DRM protected I'm
> assuming) don't play but nothing else happens in the UI either. Is this what
> I should be experiencing?

Currently music app did not handle this so that's why I filed this bug. Your test result of the DRM files is expected, but for the corrupted files looks different from my imagination(I haven't test it), probably you can attach the test file(or send it to me) then I can also test it to see what we encountered here, thanks.

> Thanks for the info!

Comment 3

[Tiffanie Shakespeare [:tif]]

Attachment: Corrupted Music File

Here is the corrupted file I used to see what happened in the simulator.

Comment 4

[Jim Porter (:squib)]

This is being worked on in bug 1149930.