Closed Bug 915629 Opened 6 years ago Closed 6 years ago

Chrome doesn't need to check the indexedDB permission

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: janv, Assigned: janv)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Chrome (JSMs and components) and chrome windows doesn't need to check the indexedDB permission.

Attaching a patch that should also fix the "Chrome windows shouldn't track quota!" assertion which appeared after temp storage landing.
Attachment #803637 - Attachment is patch: true
Attachment #803637 - Flags: review?(bent.mozilla)
Comment on attachment 803637 [details] [diff] [review]
patch

Review of attachment 803637 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!
Attachment #803637 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/3c809ee6b5af
Assignee: nobody → Jan.Varga
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Jan, are you aware that the Permission Manager will always grant permission if the principal has chrome privileges? (Just to let you know in case of that might make that code simpler, because that means that in a basic setup, there is no chrome-specific code to write, it should just work.)
(In reply to Mounir Lamouri (:mounir) from comment #4)
> Jan, are you aware that the Permission Manager will always grant permission
> if the principal has chrome privileges? (Just to let you know in case of
> that might make that code simpler, because that means that in a basic setup,
> there is no chrome-specific code to write, it should just work.)

Yeah, but in this case we want to avoid the permission check for temporary storage in content windows too, that is, the code has to be there anyway, so why don't use it for chrome too ?
(In reply to Jan Varga [:janv] from comment #5)
> Yeah, but in this case we want to avoid the permission check for temporary
> storage in content windows too, that is, the code has to be there anyway, so
> why don't use it for chrome too ?

As said, it was only "for information". I have not checked the code so if you have good reasons to do those early checks, that's great ;)
You need to log in before you can comment on or make changes to this bug.