[Gallery] Add Marionette tests

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: heroldtom, Assigned: heroldtom)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → therold
(Assignee)

Comment 1

5 years ago
Created attachment 803702 [details]
Link to Github pull request
(Assignee)

Comment 2

5 years ago
Comment on attachment 803702 [details]
Link to Github pull request

This is work in progress and should be used for review/advice at this moment only.
(Assignee)

Updated

5 years ago
Attachment #803702 - Attachment mime type: text/plain → text/html
(Assignee)

Comment 3

5 years ago
So far I have tests covering the following interactions:

- click on an image goes to fullscreen and click on the back button goes back to the overview
- in fullscreen mode one can swipe to the next image
- clicking on an image in the overview highlights it
- an image can be deleted
- a test for the test suite setup
- with regards to the image editor:
  - once can switch between the different editing modes/tabs
  - a test for adjusting exporsue
  - a test to apply an effect
  - a test to add an border
  - a test crop an image

  @djf: Do you want me to cover anything else?
Flags: needinfo?(dflanagan)
(Assignee)

Updated

5 years ago
Attachment #803702 - Flags: review?(jlal)
Attachment #803702 - Flags: review?(dmarcos)
(In reply to Tom Herold from comment #3)
> So far I have tests covering the following interactions:
> 
> - click on an image goes to fullscreen and click on the back button goes
> back to the overview
> - in fullscreen mode one can swipe to the next image
> - clicking on an image in the overview highlights it
> - an image can be deleted
> - a test for the test suite setup
> - with regards to the image editor:
>   - once can switch between the different editing modes/tabs
>   - a test for adjusting exporsue
>   - a test to apply an effect
>   - a test to add an border
>   - a test crop an image
> 
>   @djf: Do you want me to cover anything else?

I haven't thought about what can be tested here now that we have a way to do integration tests...

IIRC, the pick activity code uses the cropping code in a way that fixes the aspect ratio. You might check that that part of the code behaves correctly and that cropping always returns an image of the right relative dimensions.  But that isn't something I feel strongly about.

Thanks for working on this!
Flags: needinfo?(dflanagan)
Comment on attachment 803702 [details]
Link to Github pull request

Redirecting review to :squib my bandwidth is limited right now and I am not being very responsive... I am going to do a quick pass to give my comments but I think :squib as a media team member is a better review fit.
Attachment #803702 - Flags: review?(jlal) → review?(squibblyflabbetydoo)
Can you please attach the right pull request to the bug?
Flags: needinfo?(therold)
(Assignee)

Comment 7

5 years ago
Comment on attachment 803702 [details]
Link to Github pull request

>https://github.com/mozilla-b2g/gaia/pull/12169
><html>
>  <head>
>  <meta http-equiv="Refresh" content="2; url=https://github.com/mozilla-b2g/gaia/pull/12169">
>  </head>
>  <body>
>    Redirect to pull request 12169
>  </body>
></html>
(Assignee)

Comment 8

5 years ago
Comment on attachment 803702 [details]
Link to Github pull request

<html>
  <head>
  <meta http-equiv="Refresh" content="2; url=https://github.com/mozilla-b2g/gaia/pull/12169">
  </head>
  <body>
    Redirect to pull request 12169
  </body>
</html>
(Assignee)

Comment 9

5 years ago
Created attachment 809405 [details]
Correct link to Pull Request
Flags: needinfo?(therold)
(Assignee)

Updated

5 years ago
Attachment #809405 - Attachment mime type: text/plain → text/html
Comment on attachment 803702 [details]
Link to Github pull request

This looks good; r=me. I have a few minor changes I requested over on Github, though.
Attachment #803702 - Flags: review?(squibblyflabbetydoo) → review+
(Assignee)

Updated

5 years ago
Blocks: 924170
(Assignee)

Comment 11

5 years ago
Comment on attachment 803702 [details]
Link to Github pull request

It finally passes travis. https://travis-ci.org/mozilla-b2g/gaia/builds/13287881
Attachment #803702 - Flags: review?(dmarcos) → review?(pdahiya)
Hi Tom,
I tried running gallery marionette test after rebasing with latest master and downloading latest b2g. bin/gaia-marionette apps/gallery/test/marionette/delete_image_test.js, 
bin/gaia-marionette apps/gallery/test/marionette/fullscreen_image_test.js works perfect and passes everytime.

bin/gaia-marionette apps/gallery/test/marionette/edit_image_test.js passes first time and rerunning the test crashes b2g

doing make clean and running bin/gaia-marionette apps/gallery/test/marionette, fails it on edit_image_test with attached errors.

please try with latest b2g and see if you get the same issue.
Created attachment 825463 [details]
Edit_Image_Marionette_Test_Error.rtf
Created attachment 825464 [details]
Edit_Image_Marionette_Test_Error.rtf
Attachment #825463 - Attachment is obsolete: true
Comment on attachment 803702 [details]
Link to Github pull request

Overall tests look good, however bin/gaia-marionette apps/gallery/test/marionette is either failing on edit_image_test with the error log attached to the bug or b2g crashes. 

I have downloaded latest b2g and re-run test after make clean. The tests are passing on travis.  https://travis-ci.org/mozilla-b2g/gaia/builds/13374427

Tom, I am de-assigning myself from the review, and will suggest to get the PR looked at and  reviewed by jugglinmike or lightsofapollo. Thanks
Attachment #803702 - Flags: review?(pdahiya)
(Assignee)

Updated

5 years ago
Attachment #809405 - Flags: review?(jlal)
(Assignee)

Comment 17

5 years ago
(In reply to Tom Herold from comment #16)
> Merged:
> https://github.com/mozilla-b2g/gaia/commit/
> a6a0438df14ecf92a587793ed2dbf073e5131d15

Ups, wrong bug. Disregard this.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.