Closed Bug 915726 Opened 11 years ago Closed 11 years ago

[Web Notifications] follow-up, change notification properties from Constant to Pure

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27
Project Flags:
blocking-b2g -
Tracking Flags:
Tracking Status
firefox26 --- fixed
firefox27 --- fixed
b2g-v1.2 --- fixed

People

(Reporter: mikehenrty, Assigned: mikehenrty)

References

Details

(Whiteboard: [systemsfe][qa-])

Attachments

(1 file)

notifications-followup.patch
1.13 KB, patch
gwagner
: review+
gwagner
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Based on bz's comment https://bugzilla.mozilla.org/show_bug.cgi?id=915450#c7, we should change the notificatoin webidl attribute extensions from [Constant] to [Pure].
Assignee: nobody → mhenretty
Depends on: 915450
Whiteboard: [systemsfe]

        Attachment #803778 -
        Flags: review?(anygregor)

        Attachment #803778 -
        Flags: review?(anygregor) → review+
blocking-b2g: --- → -

    
    

    
  
Comment on attachment 803778 [details] [diff] [review]
notifications-followup.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  no bug, this fixes a too-aggressive optimization

User impact if declined:
  down the road, could cause problems if we cache notifications in C++

Testing completed (on m-c, etc.):
  built and tested

Risk to taking this patch (and alternatives if risky):
  not much risk

String or IDL/UUID changes made by this patch:
  none

        Attachment #803778 -
        Flags: approval-mozilla-aurora?

        Attachment #803778 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1590742133fa
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Whiteboard: [systemsfe] → [systemsfe][qa-]
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: