Closed Bug 915848 Opened 6 years ago Closed 6 years ago

make check_spidermonkey_style.py work correctly with git

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

I was getting very frustrated trying to use check_spidermonkey_style.py before
I realized that though there's git support included, the git support has
apparently never been tested.  Let's fix that.
--full-name is needed because normally ls-files outputs paths relative to the
directory on which git was invoked.  ../.. is needed so git outputs *all* the
files in the tree, not just the ones under js/src (since we need to look at
mfbt).

One might think that |git ls-files ../../| would be sufficient; however, this
prefixes all paths with ../../, which is undesirable.
Attachment #803947 - Flags: review?(n.nethercote)
Comment on attachment 803947 [details] [diff] [review]
make check_spidermonkey_style.py work correctly with git

Review of attachment 803947 [details] [diff] [review]:
-----------------------------------------------------------------

It's true -- I am not a git user.  Thanks for fixing this! :)
Attachment #803947 - Flags: review?(n.nethercote) → review+
...and a followup because I forgot to sync:

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c3ca75fd097
https://hg.mozilla.org/mozilla-central/rev/488c99b5d531
https://hg.mozilla.org/mozilla-central/rev/5c3ca75fd097
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Assignee: general → nfroyd
You need to log in before you can comment on or make changes to this bug.