Closed
Bug 915867
Opened 11 years ago
Closed 11 years ago
The firefox/unsupported/ pages have the old logo.
Categories
(www.mozilla.org :: Bedrock, defect, P3)
www.mozilla.org
Bedrock
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: pmac, Unassigned)
Details
(Whiteboard: [kb=1119824] r=120441)
Attachments
(1 file)
We should also port the one remaining on the SVN side to bedrock. They are: /firefox/unsupported/details/index.html # still php /firefox/unsupported/warning/ /firefox/unsupported/EOL/ /firefox/unsupported/mac/
Reporter | ||
Comment 1•11 years ago
|
||
I'll do the porting of the old page, if you'll update the Fx logo background, Steven.
Flags: needinfo?(steven)
Comment 2•11 years ago
|
||
(In reply to Paul McLanahan [:pmac] from comment #1) > I'll do the porting of the old page, if you'll update the Fx logo > background, Steven. Gladly.
Flags: needinfo?(steven)
Reporter | ||
Comment 3•11 years ago
|
||
Pointer to Github pull-request
Reporter | ||
Comment 4•11 years ago
|
||
Removed the remaining firefox/unsupported pages in r119869. After my PR is merged and in prod we can roll that out to prod as well.
Whiteboard: r=119869
Comment 5•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/ab3241a57ea6d242ff2785e671c4649d49e25f79 Bug 915867: Port unsupported/details/ billboard. Also make sure any unsupported billboards accessed at */index.html redirect to remove the filename. https://github.com/mozilla/bedrock/commit/c6a8f32ff75c8f29128ff3cad6a83e0624c1e38f Merge pull request #1227 from pmclanahan/port-unsupported-details-915867 Bug 915867: Port unsupported/details/ billboard.
Comment 6•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/34201dbca6e0b7335645444d35821b0cccec0880 Update logo on /firefox/unsupported pages Bug 915867 https://github.com/mozilla/bedrock/commit/892be602b62c393ff25227868722e334b03d9bf5 Merge pull request #1236 from sgarrity/bug-915867-unsupported-logo-updated Update logo on /firefox/unsupported pages for Bug 915867
Reporter | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 7•11 years ago
|
||
fixed on stage https://www.allizom.org/en-US/firefox/unsupported/details/ https://www.allizom.org/en-US/firefox/unsupported/warning/ https://www.allizom.org/en-US/firefox/unsupported/EOL/ https://www.allizom.org/en-US/firefox/unsupported/mac/
Reporter | ||
Comment 8•11 years ago
|
||
Background isn't updating on prod because CDN. :sgarrity, can you add the unsupported.css to the jingo-minify system just so it's minified and cache busted? Alternately we can just manually cache bust these ones, which is probably fine as they're unlikely to be touched again any time soon.
Flags: needinfo?(steven)
Reporter | ||
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 9•11 years ago
|
||
Here's a PR to use the jingo-minify system to include the css. I also reorganized the templates to use a shared base template so the CSS include HTML header/footer are shared: https://github.com/mozilla/bedrock/pull/1241
Flags: needinfo?(steven)
Reporter | ||
Updated•11 years ago
|
Whiteboard: r=119869 → [kb=1119824] r=119869
Updated•11 years ago
|
Priority: -- → P3
Comment 10•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/f63bef6da5527cb7f27b99ee57a426c4fdb07ac3 Use jingo to include CSS and share a base template Bug 915867 https://github.com/mozilla/bedrock/commit/d5c1473b090729984feeea1c0554612871d17bce Merge pull request #1241 from sgarrity/bug-915867-unsupported-logo-updated Use jingo to include CSS and share a base template for Bug 915867
Comment 11•11 years ago
|
||
fixed https://www.allizom.org/en-US/firefox/unsupported/mac/ https://www.allizom.org/en-US/firefox/unsupported/details/ https://www.allizom.org/en-US/firefox/unsupported/warning/ https://www.allizom.org/en-US/firefox/unsupported/EOL/
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Comment 12•11 years ago
|
||
verified fixed https://www.mozilla.org/en-US/firefox/unsupported/mac/ https://www.mozilla.org/en-US/firefox/unsupported/details/ https://www.mozilla.org/en-US/firefox/unsupported/warning/ https://www.mozilla.org/en-US/firefox/unsupported/EOL/
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 13•11 years ago
|
||
Activated the lang files for all of these pages in r120441.
Whiteboard: [kb=1119824] r=119869 → [kb=1119824] r=120441
Reporter | ||
Comment 14•11 years ago
|
||
Pushed lang files to production in r120443.
You need to log in
before you can comment on or make changes to this bug.
Description
•