The firefox/unsupported/ pages have the old logo.

VERIFIED FIXED

Status

www.mozilla.org
Bedrock
P3
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: pmac, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1119824] r=120441)

Attachments

(1 attachment)

We should also port the one remaining on the SVN side to bedrock.

They are:

/firefox/unsupported/details/index.html # still php
/firefox/unsupported/warning/
/firefox/unsupported/EOL/
/firefox/unsupported/mac/
I'll do the porting of the old page, if you'll update the Fx logo background, Steven.
Flags: needinfo?(steven)
(In reply to Paul McLanahan [:pmac] from comment #1)
> I'll do the porting of the old page, if you'll update the Fx logo
> background, Steven.

Gladly.
Flags: needinfo?(steven)
Created attachment 804467 [details]
Pointer to Github pull request: https://github.com/mozilla/bedrock/pull/1227

Pointer to Github pull-request
Removed the remaining firefox/unsupported pages in r119869. After my PR is merged and in prod we can roll that out to prod as well.
Whiteboard: r=119869

Comment 5

5 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/ab3241a57ea6d242ff2785e671c4649d49e25f79
Bug 915867: Port unsupported/details/ billboard.

Also make sure any unsupported billboards accessed
at */index.html redirect to remove the filename.

https://github.com/mozilla/bedrock/commit/c6a8f32ff75c8f29128ff3cad6a83e0624c1e38f
Merge pull request #1227 from pmclanahan/port-unsupported-details-915867

Bug 915867: Port unsupported/details/ billboard.

Comment 6

5 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/34201dbca6e0b7335645444d35821b0cccec0880
Update logo on /firefox/unsupported pages
Bug 915867

https://github.com/mozilla/bedrock/commit/892be602b62c393ff25227868722e334b03d9bf5
Merge pull request #1236 from sgarrity/bug-915867-unsupported-logo-updated

Update logo on /firefox/unsupported pages for Bug 915867
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Background isn't updating on prod because CDN. :sgarrity, can you add the unsupported.css to the jingo-minify system just so it's minified and cache busted? Alternately we can just manually cache bust these ones, which is probably fine as they're unlikely to be touched again any time soon.
Flags: needinfo?(steven)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Here's a PR to use the jingo-minify system to include the css. I also reorganized the templates to use a shared base template so the CSS include HTML header/footer are shared: https://github.com/mozilla/bedrock/pull/1241
Flags: needinfo?(steven)
Whiteboard: r=119869 → [kb=1119824] r=119869
Priority: -- → P3

Comment 10

5 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/f63bef6da5527cb7f27b99ee57a426c4fdb07ac3
Use jingo to include CSS and share a base template
Bug 915867

https://github.com/mozilla/bedrock/commit/d5c1473b090729984feeea1c0554612871d17bce
Merge pull request #1241 from sgarrity/bug-915867-unsupported-logo-updated

Use jingo to include CSS and share a base template for Bug 915867
Activated the lang files for all of these pages in r120441.
Whiteboard: [kb=1119824] r=119869 → [kb=1119824] r=120441
Pushed lang files to production in r120443.
You need to log in before you can comment on or make changes to this bug.