915901 - Assembler x86: change enum's names for all Float32 operations

Status: NEW

(Core :: JavaScript Engine, task, P3)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

As stated in bug 913282, comment 11:

(In reply to Nicolas B. Pierron [:nbp] from comment #11)
>> m_formatter.twoByteOp(OP2_SQRTSD_VsdWsd, (RegisterID)dst, (RegisterID)src);
> Whoa, this is confusing.  Can you declare OP2_SQRTSS_VssWss and use it here.

In this case (and all the others), OP2_SQRTSD_VsdWsd == OP2_SQRTSS_VssWss.

nbp thinks it would be better to redeclare all the enum names for the Float32 operations (so in this case, OP2_SQRTSD_VsdWsd becoming OP2_SQRTSS_VssWss), while the actual byte values are the same as for Doubles. Sean was ok for reusing the same enum values, in the Float32 patch (bug 8881090).

IMHO, it will just duplicate some code and not help that much, as we are not supposed to dive into this code that often, but I won't prevent anybody from cleaning it up :)