915924 - mach help should work without a config.status

Status: RESOLVED DUPLICATE of bug 916913

(Firefox Build System :: Mach Core, enhancement)

Description

[(Away)]

|mach help| spews an exception if you haven't run configure. It seems kind of newbie-unfriendly for a help screen ever to fail.

---

dmajor@DMAJOR-DEV /d/src/central
$ mach clobber

dmajor@DMAJOR-DEV /d/src/central
$ mach help
Error running mach:

    ['help']

The error occurred in mach itself. This is likely a bug in mach itself or a
fundamental problem with a loaded module.

Please consider filing a bug against mach by going to the URL:

    https://bugzilla.mozilla.org/enter_bug.cgi?product=Core&component=mach


If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: config.status not available. Run configure.

  File "d:\src\central\python/mach\mach\main.py", line 265, in run
    return self._run(argv)
  File "d:\src\central\python/mach\mach\main.py", line 310, in _run
    args = parser.parse_args(argv)
  File "d:\build\python\lib\argparse.py", line 1688, in parse_args
    args, argv = self.parse_known_args(args, namespace)
  File "d:\build\python\lib\argparse.py", line 1720, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "d:\build\python\lib\argparse.py", line 1929, in _parse_known_args
    stop_index = consume_positionals(start_index)
  File "d:\build\python\lib\argparse.py", line 1885, in consume_positionals
    take_action(action, args)
  File "d:\build\python\lib\argparse.py", line 1794, in take_action
    action(self, namespace, argument_values, option_string)
  File "d:\src\central\python/mach\mach\dispatcher.py", line 96, in __call__
    self._handle_main_help(parser)
  File "d:\src\central\python/mach\mach\dispatcher.py", line 168, in _handle_main_help
    if not c(instance):
  File "d:\src\central\python/mozbuild\mozbuild\base.py", line 518, in is_b2g
    return cls.substs.get('MOZ_WIDGET_TOOLKIT') == 'gonk'
  File "d:\src\central\python/mozbuild\mozbuild\base.py", line 242, in substs
    return self.config_environment.substs
  File "d:\src\central\python/mozbuild\mozbuild\base.py", line 229, in config_environment
    raise Exception('config.status not available. Run configure.')

Comment 1

[Gregory Szorc [:gps]]

Wat. This must be a recent regression.

Comment 2

[Gregory Szorc [:gps]]

I don't like duping to higher numbered bugs. But bug 916913 has a patch, so duping.

Comment 3

[(Away)]

No worries. Patch > no patch.