915986 - B2G RIL: check pin2 is null when updating FDN

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

When calling icc.updateContact("fdn", contact) without pin2 provided,
I found that if the pin2 is null, the modem won't check pin2 even when we're trying to modify a fdn contact.

But if we provide some data for pin2, then modem will try to check the pin2 is correct or not.

So RIL part should check whether pin2 is null first.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Check pin2 in RIL

Need only 1 reviewer here.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: test case for pin2 is null.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 804253 [details] [diff] [review]
Part 2: test case for pin2 is null.

Review of attachment 804253 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/aa19c3362c67
https://hg.mozilla.org/integration/b2g-inbound/rev/dd6495277f48

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aa19c3362c67
https://hg.mozilla.org/mozilla-central/rev/dd6495277f48