B2G RIL: check pin2 is null when updating FDN

RESOLVED FIXED in 1.2 FC (16sep)

Status

Firefox OS
RIL
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: allstars, Assigned: allstars)

Tracking

(Blocks: 1 bug)

unspecified
1.2 FC (16sep)
ARM
Gonk (Firefox OS)
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
When calling icc.updateContact("fdn", contact) without pin2 provided,
I found that if the pin2 is null, the modem won't check pin2 even when we're trying to modify a fdn contact.

But if we provide some data for pin2, then modem will try to check the pin2 is correct or not.

So RIL part should check whether pin2 is null first.
(Assignee)

Comment 1

4 years ago
Created attachment 804252 [details] [diff] [review]
Part 1: Check pin2 in RIL

Need only 1 reviewer here.
Attachment #804252 - Flags: review?(vyang)
Attachment #804252 - Flags: review?(htsai)
(Assignee)

Comment 2

4 years ago
Created attachment 804253 [details] [diff] [review]
Part 2: test case for pin2 is null.
Attachment #804253 - Flags: review?(vyang)
Attachment #804253 - Flags: review?(htsai)
Attachment #804252 - Flags: review?(vyang)
Attachment #804252 - Flags: review?(htsai)
Attachment #804252 - Flags: review+
Comment on attachment 804253 [details] [diff] [review]
Part 2: test case for pin2 is null.

Review of attachment 804253 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)
Attachment #804253 - Flags: review?(vyang)
Attachment #804253 - Flags: review?(htsai)
Attachment #804253 - Flags: review+
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/aa19c3362c67
https://hg.mozilla.org/integration/b2g-inbound/rev/dd6495277f48
https://hg.mozilla.org/mozilla-central/rev/aa19c3362c67
https://hg.mozilla.org/mozilla-central/rev/dd6495277f48
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → 1.2 FC (16sep)

Updated

4 years ago
Blocks: 935399

Updated

3 years ago
Blocks: 1157082
You need to log in before you can comment on or make changes to this bug.