915992 - [CostControl] Costcontrol is sending the SMS for Postpaid SIM after call-end in (VIVO configuration) due to default Plantype/Settings are Prepaid,causing the call rejected frequently by the Vivo network

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Leo]

1. Title : Costcontrol is sending the SMS for Postpaid SIM after each call-end in (VIVO configuration) due to default Plantype/Settings are Prepaid,causing the call rejected frequently by the Vivo network.
2. Precondition : Use the postpaid SIM VIVO(MCC_MNC:724-10)
3. Tester's Action : Make the call continuously for the same number.Call will be rejected by the network due to SMS sent by the costcontrol app.
4. Detailed Symptom (ENG.) :For Postpaid SIM is inserted and the default config for VIVO is prepaid,due to that costcontrol is sending balance SMS for each call-end.
6.Reproducibility: Y
1)Frequency Rate : 100%\
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: 0d5a9a7577f16b6a72a982148c6f509ee1714ea2(Gecko-499c1f8ea7ad0cdaa7086214278e2944b8a2ea33)
9.Personal email id: [e-mail]

Comment 1

[Leo]

Attachment: Log.7z

The SIM card is postpaid SIM, but SMS is sent because default setting is prepaid and user didn't change the setting.
This APP log shows us the costcontrol application sent SMS.

APP LOG          //CostControl APP Default setting log
09-12 21:18:01.148 D/SMS_QC_B2G(  135): Sending SMS, Recipient 4850, Body 00000000000000000000000000000000OWD20130913001801011100102

Why the default settings are Prepaid?
Is there any specific reason to choose Prepaid?
While Costcontrol FTE configuration user will be promted to choose the Plantype,
if he choose wrong plantype,this issue will happen?

Comment 2

[Salvador de la Puente González [:salva]]

(In reply to Leo from comment #1)
> Created attachment 804266 [details]
> Log.7z
> 
> The SIM card is postpaid SIM, but SMS is sent because default setting is
> prepaid and user didn't change the setting.
> This APP log shows us the costcontrol application sent SMS.

Do you mean the SMS is sent event if the user did not pass the Cost Control application configuration? In this case, it is an unexpected case and a bug.

> 
> APP LOG          //CostControl APP Default setting log
> 09-12 21:18:01.148 D/SMS_QC_B2G(  135): Sending SMS, Recipient 4850, Body
> 00000000000000000000000000000000OWD20130913001801011100102
> 
> Why the default settings are Prepaid?

It was specified this way in wireframes. Although is true it should do nothing while the application is still not configured.

> Is there any specific reason to choose Prepaid?

I don't know, ping UX.

> While Costcontrol FTE configuration user will be promted to choose the
> Plantype,
> if he choose wrong plantype,this issue will happen?

Yes, he should choose the option according to his real plantype.

Comment 3

[Leo]

Do you mean the SMS is sent event if the user did not pass the Cost Control application configuration? In this case, it is an unexpected case and a bug.

Yes,Just i flashed the device and i didn't configure the Costcontrol application.
Make the call,the message_handler.js is receiving the "telephony-call-ended" event and the default Plantype="Prepaid" so that costcontrol is sending SMS for balance/Topup request.

Same case may happen for sms-sent,sms-received case without FTE configuration.

Comment 4

[Salvador de la Puente González [:salva]]

Then it is a bug. We should not send any message if the FTE configuration has not been passed.

Comment 5

[Leo]

This bug contains 3 types of STRs.

1.Without Costcontrol FTE configure-->This  is a bug.
2.With proper/correct Costcontrol FTE configuration--->This issues is not reproduced,tested 200 times.
(For Postpaid SIM,User selects the plantype as Postpaid in FTE and for Prepaid SIM,User selects the Plantype as Prepaid)
3.With wrong configuration-->Dont know in this case the issue will be reproduced or not
(For Postpaid SIM,User selects the plantype as Prepaid in FTE and for Prepaid SIM,User selects the Plantype as Postpaid)

For case3: This is the user responsibility to choose the correct plantype(as per Comment 2)

Comment 6

[Leo]

Hi Salva,

Shall we change default Plantype to "Postpaid" to stop sending SMS for non-configured SIM?

Comment 7

[Leo]

Attachment: Proposed patch

Hi Salva,

The attached patch contains the default plantype for non-configured(Not yet passed FTE) case i changed to "postpaid".

Here we can not change the plantype to null or undefined due to startFTE() in common.js will expect the proper mode.

So,please provid eme your feedback,based on that i will raise the pull request.

Comment 8

[Salvador de la Puente González [:salva]]

Comment on attachment 805213 [details] [diff] [review]
Proposed patch

It looks ok but please, check the FTE wizard behaviour has not been. Asking Francisco for some testing as I will be AFK this week.

Comment 9

[Preeti Raghunath(:Preeti)]

Salva,

Can you please review the patch?

Comment 10

[Leo]

Hi Salva,

Would you please review this patch and we wanted to take this patch.

Thanks!
Leo

Comment 11

[Salvador de la Puente González [:salva]]

Reviewing.

Comment 12

[Salvador de la Puente González [:salva]]

Comment on attachment 805213 [details] [diff] [review]
Proposed patch

Simple fix. Anyway, please make the PR.

Thank you.

Comment 13

[Leo]

Attachment: Pointer to Pull Request: https://github.com/mozilla-b2g/gaia/pull/12387

Hi Salva,

Please review the attached PR for the same.

Thanks!
Leo

Comment 14

[Salvador de la Puente González [:salva]]

Comment on attachment 809051 [details]
Pointer to Pull Request: https://github.com/mozilla-b2g/gaia/pull/12387

Thank you Sireesha. Let's wait until Gaia master is open again.

Comment 15

[Salvador de la Puente González [:salva]]

Master: 16ac4d4db7b17ecddada3530388109c798485638

Comment 16

[James Lal [:lightsofapollo]]

Uplifted 16ac4d4db7b17ecddada3530388109c798485638 to:
v1-train: 39f89b8267fcdeb4a2cb81868309634347f13ab4
v1.2: 93ade24ad81496c82b6b15fce029d667b0871107

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 39f89b8267fcdeb4a2cb81868309634347f13ab4