916032 - pick activity of video unable to choose file

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

The pick activity of video only shows videos but unable to pick one.

STR:
  1. open mms and new message
  2. create attachment and choose video
  3. tap any video
  4. there is no checkbox at the right-top corner <= error

The following message can be found at logcat:
E/GeckoConsole( 1887): [JavaScript Error: "thumbnailList is undefined" {file: "app://video.gaiamobile.org/js/video.js" line: 967}]

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

blocks 908380.

This is a regression bug caused by patch of bug 908380

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

The root cause of this bug is that "showPickView" is called before init and thumbnailList is initialized at init function.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: create object earlier.

Move the thumbnailList creation to the loading of file. So, it will always be earlier than pick activity.

Comment 4

[David Flanagan [:djf]]

Comment on attachment 804338 [details]
create object earlier.

This is a simple change, and it is fine with me if you land it.

I think a better fix, however, would be to move the call to mozSetMessageHandler() into your init() function so that you don't trigger the pick until you are sufficiently initialized to handle it.

Note that you can also use navigator.mozHasPendingMessage() to find out whether you will be getting a pick activity. That way you can do different initialization depending on what it returns.  (Gallery uses mozHasPendingMessage() if you want to see an example)

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

David, 

Thanks for your suggestion. I will open another bug and start to do it. But to have pick workable, I will land it now.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/726b5aa6e467a25a95085834ed79e8c90abe658d