Closed Bug 916037 Opened 11 years ago Closed 11 years ago

Follow up bug for writing tests for swiper.js

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

Status:
RESOLVED FIXED
Milestone:
1.2 C2(Oct11)
Project Flags:
blocking-b2g koi+
Tracking Flags:
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: jcheng, Assigned: steveck)

Details

Attachments

(1 file)

pull-request.html
359 bytes, text/html
yurenju
: review+
etienne
: review+
Details 
Follow up bug for writing test on bug 913378
Assignee: nobody → schung
blocking-b2g: --- → koi+
This might be a system/dialer joined task since the swiper lives in both.
And we will probably need to look at integrations tests for this.
Summary: Follow up bug for writing test on bug 913378 → Follow up bug for writing tests for swiper.js
Attached file pull-request.html — 
Hi Etienne, I add unit test for swiper widget with small bug fixing and css clean up. If you still feel integration test is important for this widget, I'll commit another patch for that, thanks.
Attachment #809789 - Flags: review?(etienne)
Comment on attachment 809789 [details]
pull-request.html

Since this bug is only about swiper and unit test, also set Yuren as reviewer.
Attachment #809789 - Flags: review?(yurenju.mozilla)
Comment on attachment 809789 [details]
pull-request.html

r=yurenju if nits addressed.
Attachment #809789 - Flags: review?(yurenju.mozilla) → review+
Comment on attachment 809789 [details]
pull-request.html

Added some comments on github but Yuren's review is enough here.

Thanks for pushing to get this done Steve!
Attachment #809789 - Flags: review?(etienne)
Comment on attachment 809789 [details]
pull-request.html

Hi Yuren/Etienne, I've updated the patch based on the comments, thanks for the review.
Attachment #809789 - Flags: review?(etienne)
Comment on attachment 809789 [details]
pull-request.html

All good, thanks! Travis looks very happy :)
Attachment #809789 - Flags: review?(etienne) → review+
Target Milestone: --- → 1.2 QE1(Oct11)
Merged in master : 64ba02f7bbf70a1877ba9dad6889a17cd25b1d35

Thanks!
status-b2g-v1.2: --- → affected
Looks like we forgot to close this one.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Uplifted 64ba02f7bbf70a1877ba9dad6889a17cd25b1d35 to:
v1.2: b4d10ca8e15f6379f1e17fcd39e44c79dd00cfdd
status-b2g-v1.2: affected → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: