Closed Bug 916039 Opened 6 years ago Closed 6 years ago

Differential Testing: Different output message involving eval

Categories

(Core :: JavaScript Engine, defect, major)

x86
macOS
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: gkw, Assigned: jandem)

References

(Blocks 2 open bugs)

Details

(Keywords: regression, testcase)

Attachments

(1 file)

try {
    (function() {
        "use strict";
        eval("\
            print(this)\
        ");
    })()
} catch (e) {}

prints "[object global]" in js opt shell on m-c changeset b9029b1de410 with --ion-eager, but prints "undefined" without any CLI arguments.

My configure flags are:

--enable-optimize --disable-debug --enable-profiling --enable-gczeal --enable-debug-symbols --enable-methodjit --enable-type-inference --disable-tests --enable-more-deterministic --with-ccache --enable-threadsafe <other NSPR options>
Flags: needinfo?(jdemooij)
Attached patch PatchSplinter Review
Oops, very recent regression. We wrap |this| in eval scripts now but shouldn't do this in strict mode.
Assignee: general → jdemooij
Status: NEW → ASSIGNED
Attachment #804391 - Flags: review?(bhackett1024)
Flags: needinfo?(jdemooij)
Attachment #804391 - Flags: review?(bhackett1024) → review+
autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   http://hg.mozilla.org/mozilla-central/rev/aca02ab3f2d3
user:        Jan de Mooij
date:        Thu Sep 12 11:14:20 2013 +0200
summary:     Bug 914341 - Fix BC to wrap primitive |this| in eval scripts. r=djvj

Yep, recent regression from bug 914341 is likely.
Blocks: 914341
Keywords: regression
https://hg.mozilla.org/mozilla-central/rev/0be8a65a6c69
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.