Closed
Bug 916044
Opened 12 years ago
Closed 12 years ago
[System] Allow the apn.json database generator to handle correctly MCC codes starting with 0.
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaoo, Assigned: jaoo)
References
Details
(Whiteboard: [systemsfe][qa-])
Attachments
(1 file, 1 obsolete file)
|
4.24 KB,
patch
|
kaze
:
review+
|
Details | Diff | Splinter Review |
The apn.json database generator strips out the most left 0 in the MCC code if they exist.
|
Assignee | |
Comment 1•12 years ago
|
||
Comment on attachment 804342 [details] [diff] [review]
query-fix-padleft-mcc.patch
Fabien, this fix allow us to use MCC codes starting with 0 for unit tests. Would you take a look a it for a quick review please? Thanks.
Attachment #804342 -
Flags: review?(kaze)
|
|
Assignee | |
Comment 2•12 years ago
|
||
New version of the patch, tests were not passing.
Attachment #804342 -
Attachment is obsolete: true
Attachment #804342 -
Flags: review?(kaze)
Attachment #804362 -
Flags: review?(kaze)
|
||
Updated•12 years ago
|
Whiteboard: [systemsfe]
|
||
Comment 3•12 years ago
|
||
Comment on attachment 804342 [details] [diff] [review]
query-fix-padleft-mcc.patch
LGTM, thanks Jose!
Attachment #804342 -
Flags: review+
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 804362 [details] [diff] [review]
916044.patch
Ooops, I r+’ed the wrong patch. There it is.
Attachment #804362 -
Flags: review?(kaze) → review+
|
|
||
Updated•12 years ago
|
Attachment #804342 -
Flags: review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Updated•12 years ago
|
Whiteboard: [systemsfe] → [systemsfe][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•