Closed
Bug 916050
Opened 11 years ago
Closed 11 years ago
We can save 700-1000kbs of memory loading confirm dialog in a lazy mode and deleting IccHelper when is finished
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(blocking-b2g:koi+, b2g-v1.2 fixed)
People
(Reporter: crdlc, Assigned: crdlc)
References
Details
Attachments
(1 file)
We can save 700-1000kbs of memory loading confirm dialog in a lazy load and deleting IccHelper when is finished
|
Assignee | |
Updated•11 years ago
|
blocking-b2g: --- → koi?
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•11 years ago
|
Summary: We can save 700-1000kbs of memory loading confirm dialog in a lazy load and deleting IccHelper when is finished → We can save 700-1000kbs of memory loading confirm dialog in a lazy mode and deleting IccHelper when is finished
|
|
Assignee | |
Comment 1•11 years ago
|
||
Please Carmen take a look to IccHelper part. I think that when the task is performed we can delete those variables. Thanks
Attachment #804352 -
Flags: review?(cjc)
Attachment #804352 -
Flags: review?(21)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 804352 [details]
Patch v1
r+ if you move the showAppDialog code out out the homescreen.js file.
Attachment #804352 -
Flags: review?(21) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
All suggestions were addressed, waiting for travis results right now
|
|
Assignee | |
Comment 4•11 years ago
|
||
Merged into master: https://github.com/mozilla-b2g/gaia/commit/10f41aa0e9a853694d9aa66ba3fc0981e61fd7cb
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•11 years ago
|
Attachment #804352 -
Flags: review?(cjc)
|
||
Updated•11 years ago
|
blocking-b2g: koi? → koi+
|
||
Comment 5•11 years ago
|
||
Uplifted 10f41aa0e9a853694d9aa66ba3fc0981e61fd7cb to: v1.2 already had this commit
status-b2g-v1.2:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•