Closed Bug 916050 Opened 9 years ago Closed 9 years ago

We can save 700-1000kbs of memory loading confirm dialog in a lazy mode and deleting IccHelper when is finished

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

RESOLVED FIXED
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

Attachments

(1 file)

We can save 700-1000kbs of memory loading confirm dialog in a lazy load and deleting IccHelper when is finished
blocking-b2g: --- → koi?
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Summary: We can save 700-1000kbs of memory loading confirm dialog in a lazy load and deleting IccHelper when is finished → We can save 700-1000kbs of memory loading confirm dialog in a lazy mode and deleting IccHelper when is finished
Attached file Patch v1
Please Carmen take a look to IccHelper part. I think that when the task is performed we can delete those variables. Thanks
Attachment #804352 - Flags: review?(cjc)
Attachment #804352 - Flags: review?(21)
Comment on attachment 804352 [details]
Patch v1

r+ if you move the showAppDialog code out out the homescreen.js file.
Attachment #804352 - Flags: review?(21) → review+
All suggestions were addressed, waiting for travis results right now
Merged into master:

https://github.com/mozilla-b2g/gaia/commit/10f41aa0e9a853694d9aa66ba3fc0981e61fd7cb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 916827
Attachment #804352 - Flags: review?(cjc)
Depends on: 916936
blocking-b2g: koi? → koi+
Uplifted 10f41aa0e9a853694d9aa66ba3fc0981e61fd7cb to:
v1.2 already had this commit
You need to log in before you can comment on or make changes to this bug.