[FDN] “OK” button should be disabled when adding a new contact

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kaze, Assigned: kaze)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
STR:
 • Settings > Call Settings > Fixed dialing numbers
 • make sure FDN is enabled
 • Authorized numbers
 • add a new FDN contact

Expected:
 • [OK] is disabled until the Name and Number fields are non-empty

Actual:
 • [OK] is always enabled

Bonus: not sure the button should be “OK” — so far we’ve rather used “Done” for such cases.
(Assignee)

Updated

5 years ago
Assignee: nobody → kaze
Depends on: 888912
(Assignee)

Comment 1

5 years ago
Created attachment 804403 [details]
link to pull request

https://github.com/mozilla-b2g/gaia/pull/12215
Attachment #804403 - Flags: review?(arthur.chen)
Comment on attachment 804403 [details]
link to pull request

r=me with the comment addressed. Thanks.
Attachment #804403 - Flags: review?(arthur.chen) → review+
(Assignee)

Comment 3

5 years ago
Merged on master: https://github.com/mozilla-b2g/gaia/commit/275ca2cd9ccd7e63ee313e570d6e461d26bf1135
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.