Closed
Bug 916061
Opened 11 years ago
Closed 11 years ago
[FDN] “OK” button should be disabled when adding a new contact
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kaze, Assigned: kaze)
References
Details
Attachments
(1 file)
STR: • Settings > Call Settings > Fixed dialing numbers • make sure FDN is enabled • Authorized numbers • add a new FDN contact Expected: • [OK] is disabled until the Name and Number fields are non-empty Actual: • [OK] is always enabled Bonus: not sure the button should be “OK” — so far we’ve rather used “Done” for such cases.
|
Assignee | |
Comment 1•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/12215
Attachment #804403 -
Flags: review?(arthur.chen)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 804403 [details]
link to pull request
r=me with the comment addressed. Thanks.
Attachment #804403 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Merged on master: https://github.com/mozilla-b2g/gaia/commit/275ca2cd9ccd7e63ee313e570d6e461d26bf1135
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•