916068 - Can't change timezone if we are not connected to a voice network

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Hubert Figuiere [:hub]]

I just reflashed my inari with today master.

In the FTE, Date & Time, the timezone is set to GMT. When I tap the top "change" button I get an empty list. Same for the one next to "GMT".

Comment 1

[Sarah Parsons]

This issue was reproduced as far back as the 8/28 Build ID: 20130828040202. It seems as though it can only  be reproduced when there is no SIM inserted in the device.

Environmental Variables
Build ID: 20130828040202
Gecko: http://hg.mozilla.org/mozilla-central/rev/416075f77249
Gaia: eb48d3682e045c94b650323b5a55898afdf3e3b1
Platform Version: 26.0a1
RIL Version: 01.02.00.019.043 


Last working on Buri 1.2 Build ID: 20130827040201

Environmental Variables
Build ID: 20130827040201
Gecko: http://hg.mozilla.org/mozilla-central/rev/e42dce3209da
Gaia: 599214a0f41eece076dc83cd85f5b27f8cfe67f2
Platform Version: 26.0a1
RIL Version: 01.02.00.019.043

Comment 2

[Hubert Figuiere [:hub]]

Actually that phone has a SIM card, but it is disabled (settings show "????"). (it is one of the SIM card from TEF that we got in Madrid)

Comment 3

[Sarah Parsons]

Interesting, we are using AT&T SIM's and can only repro when no SIM is inserted... 

(In reply to Hubert Figuiere [:hub] from comment #2)
> Actually that phone has a SIM card, but it is disabled (settings show
> "????"). (it is one of the SIM card from TEF that we got in Madrid)

Comment 4

[Hubert Figuiere [:hub]]

(In reply to Sarah Parsons from comment #3)
> Interesting, we are using AT&T SIM's and can only repro when no SIM is
> inserted... 

But as I said, I suspect the SIM card has been disabled by the carrier.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

As I investigated and documented in bug 923775, this is due to the fact tz.json is not copied into application.zip.

This bug affects Settings app too.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Yuren, according to regression range, this might be a regression from bug 905096.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

OK, bug 905096 doesn't look like to be the offending commit....

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Wait, maybe missing json files is not the cause.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

OK, the error I got is:
[JavaScript Error: "TypeError: conn.voice.network is null" {file: "app://settings.gaiamobile.org/shared/js/tz_select.js" line: 43}]

which I can fix. I am not sure if there are other causes, but I am going to submit a patch on this bug.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch

Due to Summit I am flagging anyone on the Settings app module and see how response first. This is really trivial.

Triage: this should be koi+ because w/o this patch devices w/o telephony will not be able to switch timezones.

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

One the other hand, I might have a phone with a broken RIL ... but I think our code should be more resistant to API breakage.

Comment 15

[Evelyn Hung]

Comment on attachment 813987 [details] [diff] [review]
Patch

r=me, thanks for picking the JS error and fixing it.

Clear other review flags.

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

koi+ because of bug 916068 is marked so.

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Correction, bug 911917.

Comment 18

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Test passes: https://travis-ci.org/timdream/gaia/builds/12220806

master: https://github.com/mozilla-b2g/gaia/commit/c3cc92096f408e12ea65dc95e08a0f5a4c19fdb0

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted c3cc92096f408e12ea65dc95e08a0f5a4c19fdb0 to:
v1.2: e96514bc8a47669f523a5abe724b3834cefeb0f9

Comment 23

[Wayne Chang [:wchang]]

Hi Tim,

As discussed this needs to land on HD+ too for the duped bug 925506

Comment 24

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: c829a2042594b6c3a4899ee27979799a0f301534

Comment 25

[Al Tsai [:atsai]]

[2013/10/21 Helix Testing]
Gaia:     c829a2042594b6c3a4899ee27979799a0f301534
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019
BuildID   20131015042201
Version   18.0