Closed Bug 916087 Opened 7 years ago Closed 7 years ago

[BB] [Action Menu] Add functionality to headers

Categories

(Firefox OS Graveyard :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sergiov, Assigned: arnau)

References

Details

Attachments

(3 files)

Attached image Action Menu Navigation
In order to create nested lists, we need to add the "back" functionality to headers.
Assignee: nobody → arnau
Blocks: 876291
Attached file patch in github
Please check /shared/style/action_menu/header_actions.html
Attachment #807434 - Flags: review?(igonzaleznicolas)
Comment on attachment 807434 [details]
patch in github

I've added a couple of nits, nothing important (but let's fix it :D)

I don't see the implementation for the ">" button icon which btw we already have one in buttons.css that is exactly being used to switch between deep navigational models (.icon-view), can we use it instead of the one addressed in the design spec?

Once we've added that icon case, i highly recommend to create another html file that illustrates the use of second level actions and link to that file from one of the actions with ">" icon in the index.html.
Attachment #807434 - Flags: review?(igonzaleznicolas)
Attachment #807434 - Flags: review+
Attachment #807434 - Flags: feedback?(sergiov)
Sergi, could you please check the screenshots? as the close button in the header has now changed.
Thx!
(In reply to Arnau March from comment #5)
> Sergi, could you please check the screenshots? as the close button in the
> header has now changed.
> Thx!

Looks good.
Merged (db96687701cb9db7e409d993df9c7af54666da46)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.