916101 - New preferences warning isn't useful - should contain name of pref

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect)

Description

[Mike Kaply [:mkaply]]

There's a new preference warning that looks like this:

[08:24:54.501] Warning: attempting to write 9311 bytes to preference config. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file.

It's not very helpful because it doesn't contain the name of the preference.

The name of the preference should in the warning.

Comment 1

[Wesley]

> [08:24:54.501] Warning: attempting to write 9311 bytes to preference config.

The name of the preference is CONFIG.
And yes, the full name would help more.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Use getPrefName

getPrefName converts the branch pref into the entire pref name.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b49502604e7c

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b49502604e7c