Closed Bug 916134 Opened 10 years ago Closed 7 years ago

Rename emulator to emulator-ics

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: catlee, Unassigned)

References

Details

(Whiteboard: [b2g])

Attachments

(7 files, 2 obsolete files)

braindump patch
1.67 KB, patch
coop
: review+
RyanVM
: checked-in-
Details | Diff | Splinter Review
trychooser patch
4.44 KB, patch
emorley
: review+
RyanVM
: checked-in-
Details | Diff | Splinter Review
production-masters patch
3.18 KB, patch
mozilla
: review+
RyanVM
: checked-in-
Details | Diff | Splinter Review
puppet patch
2.58 KB, patch
mozilla
: review+
RyanVM
: checked-in-
Details | Diff | Splinter Review
puppet-manifests patch
2.66 KB, patch
mozilla
: review+
RyanVM
: checked-in-
Details | Diff | Splinter Review
buildbot-configs patch v2
17.90 KB, patch
mozilla
: review+
RyanVM
: checked-in-
Details | Diff | Splinter Review
buildbotcustom patch v2
4.71 KB, patch
mozilla
: review+
RyanVM
: checked-in-
Details | Diff | Splinter Review 
Just to help keep things clear, I think we should rename the 'emulator' builds to be 'emulator_ics'. We're going to be doing them for a while!
Assignee: nobody → ryanvm
Depends on: 916814
Attached patch buildbot-configs patch (obsolete) — — Splinter Review 
Please look over these with a fine tooth comb, because I am not guaranteeing that I've found everything and the emulator name is pretty deeply embedded all over the place.
Attachment #805365 - Flags: review?(catlee)
Attached patch braindump patch — — Splinter Review 
Also adds support to emulator-jb builds.
Attachment #805372 - Flags: review?(coop)
Attached patch trychooser patch — — Splinter Review 

        Attachment #805373 -
        Flags: review?(emorley)

    
  

        Attachment #805373 -
        Flags: review?(emorley) → review+

    
    

    
  
Comment on attachment 805372 [details] [diff] [review]
braindump patch

Review of attachment 805372 [details] [diff] [review]:
-----------------------------------------------------------------

Are there eng builds for these also? Or nightlies?

        Attachment #805372 -
        Flags: review?(coop) → review+

    
    

    
  
Comment on attachment 805365 [details] [diff] [review]
buildbot-configs patch

I have no clue if buildbot-configs/mozilla-tests/BuildSlaves.py.template needs updating or not.

    
    

    
  
(In reply to Chris Cooper [:coop] from comment #6)
> Are there eng builds for these also? Or nightlies?

Currently, there are only dep builds, no other variants.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        buildbotcustom patch (obsolete)
        — 
          — Splinter Review
      

    


  
Looks like this is just a unit test update?

        Attachment #805384 -
        Flags: review?(bhearsum)

    
    

    
  
Comment on attachment 805384 [details] [diff] [review]
buildbotcustom patch

Review of attachment 805384 [details] [diff] [review]:
-----------------------------------------------------------------

I don't feel comfortable reviewing this...probably better for Aki or Catlee.

        Attachment #805384 -
        Flags: review?(catlee)

        Attachment #805384 -
        Flags: review?(bhearsum)

        Attachment #805384 -
        Flags: review?(aki)

    
    

    
  
Some meetings to get to. AFAICT, I still need to patch mozharness, puppet-manifests, and puppet.

    
    

    
  
Nevermind to mozharness.

    
    

    
  
Taking /puppet-manifests/modules/buildmaster/templates/BuildSlaves-tests.py.erb word for it that it shouldn't be manually edited.

    
    

    
  
Same for puppet. So I guess that's all the patches I intend to create for this bug. Let me know if I'm missing anything.

    
    

    
  
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #13)
> Taking
> /puppet-manifests/modules/buildmaster/templates/BuildSlaves-tests.py.erb
> word for it that it shouldn't be manually edited.

Pretty sure the template says don't manually edit, so that the file that's generated isn't manually edited.

We still have to patch the template.

        Attachment #805378 -
        Flags: review?(aki) → review+

        Attachment #805384 -
        Flags: review?(aki) → review+

        Attachment #805384 -
        Flags: review?(catlee)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        puppet patch
        — 
          — Splinter Review
      

    


  

        Attachment #805454 -
        Flags: review?(aki)

        Attachment #805454 -
        Flags: review?(aki) → review+

        Attachment #805455 -
        Flags: review?(aki) → review+

    
    

    
  


  
BuildSlaves.py.template does need updating

        Attachment #805365 -
        Attachment is obsolete: true

        Attachment #805365 -
        Flags: review?(catlee)

        Attachment #805466 -
        Flags: review?(aki)

    
    

    
  


  
Add an emulator -> emu mapping to common.py due to a ValueError over the name being too long

        Attachment #805384 -
        Attachment is obsolete: true

        Attachment #805480 -
        Flags: review?(aki)

        Attachment #805466 -
        Flags: review?(aki) → review+

        Attachment #805480 -
        Flags: review?(aki) → review+

    
    

    
  
Backing out, since we missed the in-tree portion.

http://hg.mozilla.org/mozilla-central/file/2f0e38f79610/b2g/config/emulator

* copy b2g/config/emulator to b2g/config/emulator-ics
* move b2g/config/emulator-ics/releng-emulator.tt to b2g/config/emulator-ics/releng-emulator-ics.tt
* add "upload_platform": "emulator-ics", to emulator-ics/config.json, like http://hg.mozilla.org/mozilla-central/file/2f0e38f79610/b2g/config/emulator-jb/config.json#l15 (so we upload as emulator-ics, instead of "generic")
* land on b2g-inbound, let merge into all mozilla-central trees
* get approval to land on aurora, b2g18* branches
* land the above patches
* reconfig
* verify
* nuke b2g/config/emulator/ in-tree everywhere

    
    

    
  
ARGH, sunuva...

Will revise, sorry.

        Attachment #805372 -
        Flags: checked-in+ → checked-in-

        Attachment #805373 -
        Flags: checked-in+ → checked-in-

        Attachment #805378 -
        Flags: checked-in+ → checked-in-

        Attachment #805454 -
        Flags: checked-in+ → checked-in-

        Attachment #805466 -
        Flags: checked-in+ → checked-in-

        Attachment #805480 -
        Flags: checked-in+ → checked-in-
Depends on: 921071

    
    

    
  
Comment on attachment 805480 [details] [diff] [review]
buildbotcustom patch v2

Looks like this never got backed out.

        Attachment #805480 -
        Flags: checked-in- → checked-in+

    
    

    
  
This is hitting failures in releng-ci that I can't make any sense of. AFAICT, the changes needed for this test landed where they needed to. Since we've basically missed our best window for landing this today already and I can't seem to get any help sorting this out in #releng, I'm backing it out.

Traceback (most recent call last):
  File "/builds/buildbot/tests1-linux/lib/python2.7/site-packages/buildbot-0.8.2_hg_0ba2f2a46a93_production_0.8-py2.7.egg/buildbot/scripts/runner.py", line 1042, in doCheckConfig
    ConfigLoader(configFileName=configFileName)
  File "/builds/buildbot/tests1-linux/lib/python2.7/site-packages/buildbot-0.8.2_hg_0ba2f2a46a93_production_0.8-py2.7.egg/buildbot/scripts/checkconfig.py", line 31, in __init__
    self.loadConfig(configFile, check_synchronously_only=True)
  File "/builds/buildbot/tests1-linux/lib/python2.7/site-packages/buildbot-0.8.2_hg_0ba2f2a46a93_production_0.8-py2.7.egg/buildbot/master.py", line 652, in loadConfig
    exec f in localDict
  File "/builds/buildbot/tests1-linux/master/master.cfg", line 146, in <module>
    B2G_BRANCH_UNITTEST_VARS['platforms'])
  File "/builds/buildbot/tests1-linux/lib/python2.7/site-packages/buildbotcustom/misc.py", line 1768, in generateTalosBranchObjects
    if platform_config.get('is_mobile', False):
AttributeError: 'NoneType' object has no attribute 'get'

Unassigning myself from this bug. Someone from releng will have to take this and finish it, since I'm obviously out of my league.
Assignee: ryanvm → nobody

    
    

    
  
Comment on attachment 805480 [details] [diff] [review]
buildbotcustom patch v2

Backed out.
https://hg.mozilla.org/build/buildbotcustom/rev/503b408a75fa

        Attachment #805480 -
        Flags: checked-in+ → checked-in-

    
    

    
  
Comment on attachment 805373 [details] [diff] [review]
trychooser patch

Backed out.
https://hg.mozilla.org/build/tools/rev/b084c31d84f2

        Attachment #805373 -
        Flags: checked-in+ → checked-in-

    
    

    
  
Comment on attachment 805378 [details] [diff] [review]
production-masters patch

Backed out.
https://hg.mozilla.org/build/tools/rev/b084c31d84f2

        Attachment #805378 -
        Flags: checked-in+ → checked-in-

    
    

    
  
Comment on attachment 805455 [details] [diff] [review]
puppet-manifests patch

Backed out.
https://hg.mozilla.org/build/puppet-manifests/rev/bbe6c653395c

        Attachment #805455 -
        Flags: checked-in+ → checked-in-

    
    

    
  
Comment on attachment 805466 [details] [diff] [review]
buildbot-configs patch v2

Backed out.
https://hg.mozilla.org/build/buildbot-configs/rev/a9f86e2eb31b

        Attachment #805466 -
        Flags: checked-in+ → checked-in-

    
    

    
  
Not CCing myself.
Some code from here made it into the production branches of buildbot-configs and buildbotcustom repos.
It should now be live.

    
  
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Component: General Automation → General

          You need to log in
          before you can comment on or make changes to this bug.