Closed Bug 916147 Opened 8 years ago Closed 8 years ago

jit-tests should output the test filepath relative to topsrcdir, not the absolute path

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: emorley, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When filing intermittent failure bugs for jit-tests (of which there have been many of late), each time I have to hand-trim the full filepath, so the summary isn't bloated. 

ie from the log:
{
TEST-PASS | e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug845331.js | --baseline-eager --no-ti --no-fpu
TEST-PASS | e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug845331.js | --no-baseline --no-ion
TEST-PASS | e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug845331.js | --no-baseline --no-ion --no-ti
TEST-PASS | e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug846072.js | 
TEST-PASS | e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug846072.js | --ion-eager
TEST-PASS | e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug846072.js | --ion-eager --ion-check-range-analysis
FAIL - e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug846072.js
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug846072.js | --baseline-eager: e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\js\src\jit-test\tests\baseline\bug846072.js:4:6 TypeError: can't convert this to string
}

Ideally the path relative to topsrcdir would be used instead, eg:
{
TEST-PASS | js\src\jit-test\tests\baseline\bug845331.js | --baseline-eager --no-ti --no-fpu
TEST-PASS | js\src\jit-test\tests\baseline\bug845331.js | --no-baseline --no-ion
TEST-PASS | js\src\jit-test\tests\baseline\bug845331.js | --no-baseline --no-ion --no-ti
TEST-PASS | js\src\jit-test\tests\baseline\bug846072.js | 
TEST-PASS | js\src\jit-test\tests\baseline\bug846072.js | --ion-eager
TEST-PASS | js\src\jit-test\tests\baseline\bug846072.js | --ion-eager --ion-check-range-analysis
FAIL - js\src\jit-test\tests\baseline\bug846072.js
TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\baseline\bug846072.js | --baseline-eager: js\src\jit-test\tests\baseline\bug846072.js:4:6 TypeError: can't convert this to string
}
This makes the suggested change and, since we're already touching the tinderbox output, adds complete stdout, stderr, exit-code, and timeout status dumps on failure. Seems to work locally.
Assignee: general → terrence
Status: NEW → ASSIGNED
Attachment #804547 - Flags: review?(dminor)
Blocks: 745230
Comment on attachment 804547 [details] [diff] [review]
fix_up_jittest_tinderbox_output-v0.diff

Review of attachment 804547 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and runs fine locally on my pandaboard.
Attachment #804547 - Flags: review?(dminor) → review+
https://hg.mozilla.org/mozilla-central/rev/6bd5b8cc216e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Thank you for doing this Terrence! :-)
You need to log in before you can comment on or make changes to this bug.