Closed
Bug 916207
Opened 11 years ago
Closed 11 years ago
OS X - Compose Window's sidebar close button does not have a hover or pressed state.
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 26.0
People
(Reporter: jsbruner, Assigned: jsbruner)
Details
Attachments
(1 file, 3 obsolete files)
1.71 KB,
patch
|
jsbruner
:
review+
|
Details | Diff | Splinter Review |
Right now opening the compose window and then opening the sidebar reveals a close button on the sidebar lacking a hover or active state. This patch should add those states on OS X including the retina mode...
Attachment #804569 -
Flags: review?(richard.marti)
Assignee | ||
Comment 1•11 years ago
|
||
Accidentally commented something out in that patch.
Attachment #804569 -
Attachment is obsolete: true
Attachment #804569 -
Flags: review?(richard.marti)
Attachment #804577 -
Flags: review?(richard.marti)
Comment 2•11 years ago
|
||
Comment on attachment 804577 [details] [diff] [review] Patch. Hmm, this patch doesn't apply on tip.
Attachment #804577 -
Flags: review?(richard.marti) → review-
Assignee | ||
Comment 3•11 years ago
|
||
Ouch. Accidentally messed up my working queue. This should be better.
Attachment #804577 -
Attachment is obsolete: true
Attachment #804618 -
Flags: review?(richard.marti)
Comment 4•11 years ago
|
||
Comment on attachment 804618 [details] [diff] [review] Patch. Review of attachment 804618 [details] [diff] [review]: ----------------------------------------------------------------- r+ with the nit addressed. ::: mail/themes/osx/mail/compose/messengercompose.css @@ +1392,5 @@ > .ab-closebutton { > list-style-image: url("chrome://global/skin/icons/close@2x.png") !important; > -moz-image-region: rect(0, 32px, 32px, 0); > } > + Nit, white space
Attachment #804618 -
Flags: ui-review+
Attachment #804618 -
Flags: review?(richard.marti)
Attachment #804618 -
Flags: review+
Assignee | ||
Comment 5•11 years ago
|
||
Thanks Richard!
Attachment #804618 -
Attachment is obsolete: true
Attachment #804683 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/d26eff2ae9e0
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
You need to log in
before you can comment on or make changes to this bug.
Description
•