Closed Bug 916231 Opened 11 years ago Closed 11 years ago

Add developer settings to enable the screen reader

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v1.2 fixed, b2g-v1.3 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g-v1.2 --- fixed
b2g-v1.3 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

Attachments

(1 file, 3 obsolete files)

Add screen reader toggle to developer options.
1.13 KB, patch
kaze
: review+
bajaj
: approval-gaia-v1.2+
Details | Diff | Splinter Review 
The screen reader is not ready for users, but it is ready for developers to make their apps screen-reader-ready for users!
This is based on patches in bug 914892, so no pull request yet.
Depends on: 914892
This is a string change, tried to get it in before freeze, but i may have missed that opportunity :( Anyway, I hope we could get this approved since it is only visible to developers.
Attachment #804722 - Attachment is obsolete: true
Attachment #805690 - Flags: review?(kaze)
Comment on attachment 805690 [details] [diff] [review]
Add developer option for showing a11y settings panel.

Review of attachment 805690 [details] [diff] [review]:
-----------------------------------------------------------------

makes sense, but I think we should rather show a simple “Screen reader” switch in the Developer panel at the moment. Do you mind adjusting your patch for that?
Attachment #805690 - Flags: review?(kaze) → review-
Voilà
Attachment #805690 - Attachment is obsolete: true
Attachment #806280 - Flags: review?(kaze)
Put the screen reader in a new accessibility sub-section.
Attachment #806280 - Attachment is obsolete: true
Attachment #806280 - Flags: review?(kaze)
Attachment #806293 - Flags: review?(kaze)
Comment on attachment 806293 [details] [diff] [review]
Add screen reader toggle to developer options.

Review of attachment 806293 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Eitan!
Attachment #806293 - Flags: review?(kaze) → review+
Summary: Add developer settings for showing accessibility panel → Add developer settings to enable the screen reader
Assignee: nobody → eitan
Comment on attachment 806293 [details] [diff] [review]
Add screen reader toggle to developer options.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Initial implementation of screen reader for developers. Missing piece to the feature.
[User impact] if declined: Developers could not test their web apps for accessibility for the visually impaired in Firefox OS 1.2.
[Testing completed]: Yes.
[Risk to taking this patch] (and alternatives if risky): None.
[String changes made]: None.
Attachment #806293 - Flags: approval-gaia-v1.2?
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #806293 - Flags: approval-gaia-v1.2? → approval-gaia-v1.2+
Uplifted c7803c6a23057cd3b3613f315d2fe5a5d4c83a51 to:
v1.2: 85adf28ddaac0985108b482f2babc71d83508718
status-b2g-v1.2: --- → fixed
Uplifted c7803c6a23057cd3b3613f315d2fe5a5d4c83a51 to:
v1.3 already had this commit
status-b2g-v1.3: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: