916259 - Make it easier to dump layer tree from opt & mobile

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

With this patch you can just uncomment #define MOZ_LAYERS_HAVE_LOG

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 804630 [details] [diff] [review]
patch

Review of attachment 804630 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/Layers.cpp
@@ +1225,1 @@
>  }

How about just:

if (aFile) {
fprintf(aFile, "%s\n", str.get());
} else {
printf_stderr("%s\n", str.get());
}

instead of the #ifdef ANDROID stuff?

Comment 2

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 805357 [details] [diff] [review]
patch

Review of attachment 805357 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/Layers.cpp
@@ +1216,5 @@
>    PrintInfo(str, aPrefix);
> +  if (!aFile || aFile == stderr) {
> +    printf_stderr("%s\n", str.get());
> +  } else {
> +    fprintf(FILEOrDefault(aFile), "%s\n", str.get());

fprintf(aFile,

FILEOrDefault just checks aFile again

Comment 4

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/211d895e70d1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/211d895e70d1