916262 - Replace e.me frame on First Time Experience

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Fade Rudnitsky]

Attachment: e.me's screen on First Time Experience

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.65 Safari/537.36




Expected results:

See approved design for e.me's screen on First Time Experience.
- Prepare translations, if needed

Comment 1

[Fade Rudnitsky]

What assets in which resolutions should be submitted in order for this screen to be implemented?

Comment 2

[Patryk Adamczyk [:patryk] UX]

I believe we need to cover:
320x480 and (x1.5) 480x800

Comment 3

[Fade Rudnitsky]

I meant preparing the asset of the "screenshot" shown on this screen. Is its size different on multiple resolutions?
Perhaps seeing current assets could help. Where can I find them?

Comment 4

[Fernando Campo (:fcampo)]

You can find all the assets for FTE in here https://github.com/mozilla-b2g/gaia/tree/master/apps/communications/ftu/css/images

Comment 5

[Patryk Adamczyk [:patryk] UX]

The link from Fernando should you a perspective. We don't need to worry about 2x.
But we'll need everything in this format:
> image.png
> [e-mail]

Comment 6

[Fade Rudnitsky]

Attachment: EvMe Screen on FTU @1x

Comment 7

[Fade Rudnitsky]

Attachment: EvMe Screen on FTU @1.5x

Comment 8

[Fade Rudnitsky]

Attachment: EvMe Screen on FTU @2x

Comment 9

[Fade Rudnitsky]

Thanks, Fernando and Patryk.
We have already prepared all the three versions. Added as attachments.

Feel free to implement.

Comment 10

[Fernando Campo (:fcampo)]

I think I remember something about trying to avoid specific languages on the tutorial, as that would lead to new bugs related with l10n. Is this policy still applies or did it change?

Comment 11

[Fade Rudnitsky]

In this specific case, showing search query is crucial for user to understand how it works. Can we somehow embed live text instead? If not, will have to stick with this, it was approved by Patryk and Jamie Chen.

Comment 12

[Fade Rudnitsky]

Will go with the attached resources. Please implement.

Comment 13

[Fade Rudnitsky]

Will go with the attached resources. Please implement.

Comment 14

[Ran Ben Aharon [:ranbena] EverythingMe]

Can anyone from the FTU team assign himself to this?

Comment 15

[Fernando Campo (:fcampo)]

Sure I'll take a look if I manage to get some free cycles

Comment 16

[Evyatar 'Tron' Amitay (everything.me)]

Fernando, I wanted to try and take this off your plate, but I feel I don't know enough about the strings "politics" with bug 901041 and bug 902487 hanging.

what should be the correct way to approach this?
Should I add a step in the middle, but give it the l10n key "totorial-step6" (even though it won't be the sixth)?

e.me step is designated to be the 3rd.

Comment 17

[Evyatar 'Tron' Amitay (everything.me)]

Attachment: Patch - redirect to github PR

Attaching a patch - it looks well on the device (approved by our UX guys), but I'm not sure about the FTU code itself.

Comment 18

[Fernando Campo (:fcampo)]

Having in mind the mess going on with FTU strings (as you pointed out, bug 902487 should solve it), I agree with you on the approach, as it's probably the best for the l10n guys.

As this is blocking the release for e.me for 1.2, I'm pinging someone from l10n team to confirm that this is the best approach given the time, and fix the strings on the mentione bug.

About the patch, it looks good, just need a better comment to clarify for future re-coding (on github)

Comment 19

[Fernando Campo (:fcampo)]

Comment on attachment 814034 [details]
Patch - redirect to github PR

Giving the r+ assuming that the changes proposed on github are implemented before merging ;) 
Thanks for taking this!

Comment 20

[Evyatar 'Tron' Amitay (everything.me)]

expanded on my comment, though I'm not sure it'll be enough. since I'm probably not the one who will be fixing this when the time comes, I'm willing to comment whatever you feel will make it the most understandable later on :) https://github.com/mozilla-b2g/gaia/pull/12696#discussion_r6792775

Comment 21

[Evyatar 'Tron' Amitay (everything.me)]

also can we ni? the person from l10n? even with the r+, I don't want to merge it without making sure that's the best approach.

Comment 22

[Fernando Campo (:fcampo)]

Sure, I totally forgot about it :D So ni for Pike, just to confirm that adding a 6th step string (when we only use 5) is better for l10n team than change the id of the different strings at this stage.

And the comment looks good enough for me, thanks

Comment 23

[Axel Hecht [:Pike]]

ugh, didn't we have a bug to get rid of those numbers altogether? This is the second patch that proves that design wrong.

I suggest to add this string with using a real step name, and not a number.

Comment 24

[Evyatar 'Tron' Amitay (everything.me)]

I agree, it would make it much easier to change and maintain later on. so should I simply change to "tutorial-step-evme"?

Comment 25

[Axel Hecht [:Pike]]

(In reply to Evyatar 'Tron' Amitay (everything.me) from comment #24)
> I agree, it would make it much easier to change and maintain later on. so
> should I simply change to "tutorial-step-evme"?

Sounds good.

Comment 26

[Evyatar 'Tron' Amitay (everything.me)]

no problem, updated the PR.
so with that and the r+ - is this good for landing?

Comment 27

[Fernando Campo (:fcampo)]

(In reply to Axel Hecht [:Pike] from comment #23)
> ugh, didn't we have a bug to get rid of those numbers altogether? This is
> the second patch that proves that design wrong.
That would be bug 902487, still waiting for triage to dedicate some cycles to it.

> I suggest to add this string with using a real step name, and not a number.
I would rather to change all the names in the other bug, but it's ok with me this way, having even more mess would push us to solve it quicker :)

I checked the failing tests, but doesn't seem related, so I would say we are good to merge. Do you have permissions or should I do it myself?

Comment 28

[Evyatar 'Tron' Amitay (everything.me)]

merged into master!
07b4be36173e28d9c3453a65393b482af32c671f

https://github.com/mozilla-b2g/gaia/commit/07b4be36173e28d9c3453a65393b482af32c671f

Comment 29

[Jason Smith [:jsmith]]

E.me 1.2 feature set has been taken out of scope for 1.2 at this point, so not blocking.