Closed Bug 916268 Opened 6 years ago Closed 6 years ago

Recent lockscreen redesign breaks accessibility mode

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

(Keywords: access)

Attachments

(1 file)

When screen reader is enabled, the slider goes up on the page. A relic from the 'triggered' class.
This is a regression from bug #913377.
https://github.com/mozilla-b2g/gaia/pull/12224

This does not remove all of the obsolete code. But it does take care of the screen reader issues.
Attachment #804669 - Flags: review?(timdream)
Comment on attachment 804669 [details] [diff] [review]
Remove special screen reader case in light of lockscreen redesign.

Greg, could you please give me some feedback first :)?
Attachment #804669 - Flags: feedback?(gweng)
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #3)
> Greg, could you please give me some feedback first :)?

The initial implementation to make the lock screen more screen-reader friendly was done in bug 884517. That, and the associated pull request have more background why this was needed in the first place.
Sorry for the late reply. I've applied the patch and it worked fine at the test. The code also looks good to clean the legacy parts. So maybe Tim can check it again.
Attachment #804669 - Flags: feedback?(gweng)
Attachment #804669 - Flags: review?(timdream) → review+
Tim, Greg, a favor: Could one of you accept the pull request so this goes into Master soon'ish? I'd like to do some testing today (I'm in timezone GMT+2), and this bug is blocking me from unlocking the phone. So it would be extremely helpful if this was applied well before Eitan wakes up, who is in PDT. ;) Thanks!
Assignee: nobody → eitan
You need to log in before you can comment on or make changes to this bug.