916310 - browser/base/content/test/browser_aboutHealthReport.js | Console message: [JavaScript Error: "DEPRECATION WARNING: Field 'creationDate' is deprecated

Status: RESOLVED DUPLICATE of bug 916186

(Firefox Health Report Graveyard :: Data Collection, defect)

Description

[Mats Palmgren (:mats)]

(I can't find the component for Health Report so please forward as needed)

This test generates a lot of warnings in the mochitest logs:

10:04:57     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_aboutHealthReport.js | Console message: [JavaScript Error: "DEPRECATION WARNING: Field 'creationDate' is deprecated.
10:04:57     INFO -  You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/JavaScript_OS.File/OS.File.Info#Cross-platform_Attributes
10:04:57     INFO -  resource://gre/modules/osfile/osfile_async_front.jsm 754 creationDate
10:04:57     INFO -  resource://gre/modules/HealthReport.jsm 6657 iterateDirectory
10:04:57     INFO -  resource://gre/modules/Task.jsm 233 TaskImpl_run
10:04:57     INFO -  resource://gre/modules/Promise.jsm 572 null
10:04:57     INFO -  resource://gre/modules/Promise.jsm 354 null
10:04:57     INFO -  null 0 null
10:04:57     INFO -  " {file: "resource://gre/modules/Deprecated.jsm" line: 79}]
10:04:57     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_aboutHealthReport.js | Console message: [JavaScript Error: "DEPRECATION WARNING: Field 'creationDate' is deprecated.
10:04:57     INFO -  You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/JavaScript_OS.File/OS.File.Info#Cross-platform_Attributes
10:04:57     INFO -  resource://gre/modules/osfile/osfile_async_front.jsm 754 creationDate
10:04:57     INFO -  resource://gre/modules/HealthReport.jsm 6657 iterateDirectory
10:04:57     INFO -  resource://gre/modules/Task.jsm 233 TaskImpl_run
10:04:57     INFO -  resource://gre/modules/Promise.jsm 572 null
10:04:57     INFO -  resource://gre/modules/Promise.jsm 354 null
10:04:57     INFO -  null 0 null
10:04:57     INFO -  " {file: "resource://gre/modules/Deprecated.jsm" line: 79}]
10:04:57     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_aboutHealthReport.js | Console message: [JavaScript Error: "DEPRECATION WARNING: Field 'creationDate' is deprecated.
10:04:57     INFO -  You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/JavaScript_OS.File/OS.File.Info#Cross-platform_Attributes
10:04:57     INFO -  resource://gre/modules/osfile/osfile_async_front.jsm 754 creationDate
10:04:57     INFO -  resource://gre/modules/HealthReport.jsm 6657 iterateDirectory
10:04:57     INFO -  resource://gre/modules/Task.jsm 233 TaskImpl_run
10:04:57     INFO -  resource://gre/modules/Promise.jsm 572 null
10:04:57     INFO -  resource://gre/modules/Promise.jsm 354 null
10:04:57     INFO -  null 0 null
10:04:57     INFO -  " {file: "resource://gre/modules/Deprecated.jsm" line: 79}]
10:04:57     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_aboutHealthReport.js | Console message: [JavaScript Error: "DEPRECATION WARNING: Field 'creationDate' is deprecated.
10:04:57     INFO -  You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/JavaScript_OS.File/OS.File.Info#Cross-platform_Attributes
10:04:57     INFO -  resource://gre/modules/osfile/osfile_async_front.jsm 754 creationDate
10:04:57     INFO -  resource://gre/modules/HealthReport.jsm 6657 iterateDirectory
10:04:57     INFO -  resource://gre/modules/Task.jsm 233 TaskImpl_run
10:04:57     INFO -  resource://gre/modules/Promise.jsm 572 null
10:04:57     INFO -  resource://gre/modules/Promise.jsm 354 null
10:04:57     INFO -  null 0 null

... etc ...

Comment 1

[Mats Palmgren (:mats)]

Mike, can you take a look?

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Usage of creationDate was introduced by bug 808126. Can that usage just be removed?

Discussed this a bit with Yoric on IRC, and creationDate was deprecated because it's both only available on OSX and Windows (properties are now macBirthDate/winBirthDate), and is unreliable on the platforms it is available on (depends on the filesystem).

The usage here seems redundant - its recording the creation date and last-modified date of crash dump files. AFAIK, dump files aren't touched after they've been first written - so just last-modified date should be adequate to record (and that date is reliable).

Comment 3

[Richard Newman [:rnewman]]

I think this counts as a dupe of Bug 916186.