Use proper plural forms in messageRepeats.tooltip

RESOLVED FIXED in Firefox 26

Status

()

Firefox
Developer Tools: Console
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: flod, Assigned: msucan)

Tracking

Trunk
Firefox 26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
http://hg.mozilla.org/mozilla-central/diff/9d115a405371/browser/locales/en-US/chrome/browser/devtools/webconsole.properties

messageRepeats.tooltip=%S repeats

While this works in English, this is not correct for many of the languages we support.
https://developer.mozilla.org/en-US/docs/Localization_and_Plurals

Note that you will also need a new ID for the correct string.
(Assignee)

Comment 1

5 years ago
Created attachment 804874 [details] [diff] [review]
bug-916329-1-fx-team.diff

Asking for a review but I am not sure Rob's available this weekend.

Francesco: please check this patch is fine. Thank you!
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #804874 - Flags: review?(rcampbell)
Attachment #804874 - Flags: feedback?(francesco.lodolo)
Attachment #804874 - Flags: review?(rcampbell) → review+
I am! I did! I'm going to put checkin-needed on this to get it in before uplift.
Keywords: checkin-needed
(Reporter)

Comment 3

5 years ago
Comment on attachment 804874 [details] [diff] [review]
bug-916329-1-fx-team.diff

Review of attachment 804874 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry I'm late, on a bad hotel Wi-Fi for the weekend.

Patch looks good to me, thanks to both of you for the speed :-)
Attachment #804874 - Flags: feedback?(francesco.lodolo) → feedback+
https://hg.mozilla.org/integration/fx-team/rev/dcfaf38904f7
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/dcfaf38904f7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.