Closed
Bug 916371
Opened 11 years ago
Closed 11 years ago
[from 913725] viewing makes, then logging out adds the "open" state to the makes iframe on logout
Categories
(Webmaker Graveyard :: Login, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michiel, Assigned: michiel)
References
Details
Attachments
(1 file)
One functionality problem. STR: 1) Sign in. 2) Select My Makes. 3) Close My Makes. 4) Logout 5) Login Cause: the sso-ux.js userBar.updateMakes function is calling "delete makesIFrame.onload", but this does not actually deleted the onload handler.
Attachment #804792 -
Flags: review?(schranz.m)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 804792 [details] [review] https://github.com/mozilla/login.webmaker.org/pull/160 I'm curious as to what we were doing in Popcorn Maker that didn't make this an issue, but this seems fixed. No issues with Popcorn Maker, make editor, wm.org with this patch.
Attachment #804792 -
Flags: review?(schranz.m) → review+
|
||
Comment 3•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/login.webmaker.org https://github.com/mozilla/login.webmaker.org/commit/178ebb1af701c5c71250783ee703ef9167fc7ca7 Merge pull request #160 from Pomax/bug916371 fixed nasty makes-iframe-opens-on-logout bug
landed.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•