916384 - ScriptProcessorNode should not call onaudioprocess when no other nodes are connected

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P1)

Description

[Karl Tomlinson (:karlt)]

Attachment: testcase

https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#ScriptProcessorNode
"audioprocess events are only dispatched if the ScriptProcessorNode has at least one input or one output connected."

Comment 2

[Paul Adenot (:padenot)]

Attachment: Stop calling onaudioprocess on the ScriptProcessorNode it has no inputs or outputs. r=

I had to adjust the test that checks that event fires without input XOR output.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8344726 [details] [diff] [review]
Stop calling onaudioprocess on the ScriptProcessorNode it has no inputs or outputs. r=

Review of attachment 8344726 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/ScriptProcessorNode.cpp
@@ +228,5 @@
> +    // onaudioprocess event.
> +    if (!(aStream->ConsumerCount() ||
> +          aStream->AsProcessedStream()->InputPortCount())) {
> +      return;
> +    }

We need to produce something in aOutput. I think we actually should consume any output buffers that script has already produced. Otherwise if we reconnect after some time, we'll play very old data.

So I think here we should clear our input and output buffers and set aOutput to null data before we return.

Comment 4

[Paul Adenot (:padenot)]

Attachment: Stop calling onaudioprocess on the ScriptProcessorNode it has no inputs or outputs. r=

This should address the comments.

Comment 5

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/012b1baf2b19

Comment 6

[Paul Adenot (:padenot)]

Backed out for crashes.

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=63ae0ef30e3f

Comment 7

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55e604639526

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/55e604639526