Closed Bug 916411 Opened 6 years ago Closed 6 years ago
[fugu][Buri][Calendar]The event display abnormally when title/where/notes is long
Mozilla build ID:20130902041201 Created an attachment (id=517352) pic DEFECT DESCRIPTION: The event display abnormally when title/where/notes longer REPRODUCING PROCEDURES: 1.Launch calendar app->click add button and input long characters in title/where/notes textbox->save it 2.Press the new event and enter into its detail page->the long content display in a row EXPECTED BEHAVIOUR: The long content can be wrapped automatically ASSOCIATE SPECIFICATION: TEST PLAN REFERENCE: TOOLS AND PLATFORMS USED: USER IMPACT: Medium REPRODUCING RATE: 5/5 For FT PR, Please list reference mobile's behavior:
Clone from brother
Summary: [Buri][Calendar]The event display abnormally when title/where/notes is long → [fugu][Buri][Calendar]The event display abnormally when title/where/notes is long
Not a regression, so this is not a blocker.
blocking-b2g: 1.3? → -
work in progress pull request. still waiting for blocking bugs to be merged before I rebase and resolve conflicts.
Attachment #8360773 - Flags: review?(gaye)
Comment on attachment 8360773 [details] [review] Link to github pull request Gareth, please review the pull request, just rebased and improved a little bit. Thanks.
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
Whiteboard: burirun3, burirun1.3-2 → burirun3, burirun1.3-2[p=3]
implementation is done and correct, but we are still experiencing some intermittent failures on Travis. Will probably need to wait for https://bugzilla.mozilla.org/show_bug.cgi?id=965131 to be resolved before merging the patch (or change the test logic). Adding it as a blocker for now.
Depends on: 965131
Updated the pull request. Fixed the intermittent failures by adding a delay big enough for the keyboard to hide completely before trying to click the `weekButton`. I think we can merge it and later remove the logic in case Bug 965131 gets fixed. That will allow us to merge 2 other bug fixes.
Comment on attachment 8360773 [details] [review] Link to github pull request LGTM. Feel free to merge once we change the implementation of waitForKeyboardHide to not sleep (and instead check the DOM for the keyboard's hidden attr https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/index.html#L21). Thanks!
Attachment #8360773 - Flags: review?(gaye) → review+
merged into master https://github.com/mozilla-b2g/gaia/commit/814aaec396dc1ddf8b3d55e38738be62fb10adfb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.