916411 - [fugu][Buri][Calendar]The event display abnormally when title/where/notes is long

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P1)

Description

[sync-1]

Mozilla build ID:20130902041201
 
 Created an attachment (id=517352)
 pic
 
 DEFECT DESCRIPTION:
 The event display abnormally when title/where/notes longer
 
  REPRODUCING PROCEDURES:
 1.Launch calendar app->click add button and input long characters in title/where/notes textbox->save it
 2.Press the new event and enter into its detail page->the long content display in a row
 
  EXPECTED BEHAVIOUR:
 The long content can be wrapped automatically
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 Medium
  REPRODUCING RATE:
 5/5
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: pic

Comment 3

[Jason Smith [:jsmith]]

Not a regression, so this is not a blocker.

Comment 4

[Miller Medeiros [:millermedeiros]]

Attachment: Link to github pull request

work in progress pull request. still waiting for blocking bugs to be merged before I rebase and resolve conflicts.

Comment 5

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8360773 [details] [review]
Link to github pull request

Gareth, please review the pull request, just rebased and improved a little bit. Thanks.

Comment 6

[Miller Medeiros [:millermedeiros]]

implementation is done and correct, but we are still experiencing some intermittent failures on Travis. Will probably need to wait for https://bugzilla.mozilla.org/show_bug.cgi?id=965131 to be resolved before merging the patch (or change the test logic). Adding it as a blocker for now.

Comment 7

[Miller Medeiros [:millermedeiros]]

Updated the pull request. Fixed the intermittent failures by adding a delay big enough for the keyboard to hide completely before trying to click the `weekButton`. I think we can merge it and later remove the logic in case Bug 965131 gets fixed. That will allow us to merge 2 other bug fixes.

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8360773 [details] [review]
Link to github pull request

LGTM. Feel free to merge once we change the implementation of waitForKeyboardHide to not sleep (and instead check the DOM for the keyboard's hidden attr https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/index.html#L21).

Thanks!

Comment 9

[Miller Medeiros [:millermedeiros]]

merged into master https://github.com/mozilla-b2g/gaia/commit/814aaec396dc1ddf8b3d55e38738be62fb10adfb